Fix check for new and unexpected roots

We track the "roots" in our grammar -- those productions that aren't
used in any other production.  We want to report when a new root
appears or when something that's expected to be a root no longer is
one.  However, we were reporting the latter case as the former instead
of reporting it separately as intended.  Let's fix that.

Author: traviscross

mdbook-spec/src/grammar.rs

@@ -200,8 +200,7 @@ fn check_unexpected_roots(grammar: &Grammar, diag: &mut Diagnostics) {
     .into_iter()
     .collect();
     if set != expected {
-        let new: Vec<_> = set.symmetric_difference(&expected).collect();
-        let removed: Vec<_> = expected.symmetric_difference(&set).collect();
+        let new: Vec<_> = set.difference(&expected).collect();
         if !new.is_empty() {
             warn_or_err!(
                 diag,
@@ -210,15 +209,15 @@ fn check_unexpected_roots(grammar: &Grammar, diag: &mut Diagnostics) {
                  If not, make sure it is spelled correctly and used in another production.\n\
                  The new names are: {new:?}\n"
             );
-        } else if !removed.is_empty() {
+        }
+        let removed: Vec<_> = expected.difference(&set).collect();
+        if !removed.is_empty() {
             warn_or_err!(
                 diag,
                 "Old grammar production root seems to have been removed.\n\
                  If this is expected, remove it from the `check_unexpected_roots` function.\n\
                  The removed names are: {removed:?}\n"
             );
-        } else {
-            unreachable!("unexpected");
         }
     }
 }