Skip to content

Commit c3f932c

Browse files
committed
fix: Remove confusion over :: and tool-config
1 parent 935593f commit c3f932c

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

text/3389-manifest-lint.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -207,11 +207,12 @@ Instead of `<tool>.<lint>`, we could use `<tool>::<lint>` (e.g.
207207
`"clipp::enum_glob_use"` instead of `clippy.enum_glob_use`), like in the
208208
diagnostic messages. This would make it easier to copy/paste lint names.
209209
However, with the schema being `<lint> = <level>`, this would require quoting
210-
the keys rather than leaving them as bare words. This would also cause
210+
the keys rather than leaving them as bare words. This might also cause
211211
problems for tool-level configuration. The first is that the lints wouldn't be
212-
easily grouped with their config. The second is if we use `<lint> = <level>`,
213-
we'd be mixing tool names in with lints, making it easier to conflict and
214-
harder to collect all lints to forward to a tool.
212+
easily grouped with their tool's config. The second is if we use `lints.<lint> = <level>`
213+
and tool-level configuration goes under `lints.<tool>`,
214+
then keys under `[lints]` are ambiguous as to whether they are a tool or a
215+
lint, making it harder to collect all lints to forward tools.
215216

216217
We could possibly extend this new field to `rustfmt` by shifting the focus from
217218
"lints" to "rules" (see

0 commit comments

Comments
 (0)