Skip to content

Commit fbf6f48

Browse files
committed
fix: Expand on why not :: but separate tables
1 parent 45766c4 commit fbf6f48

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

text/3389-manifest-lint.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -205,9 +205,13 @@ and other fields that are more workspace related. Instead, we used
205205

206206
Instead of `<tool>.<lint>`, we could use `<tool>::<lint>` (e.g.
207207
`"clipp::enum_glob_use"` instead of `clippy.enum_glob_use`), like in the
208-
diagnostic messages. This would make it easier to copy/paste lint names but it
209-
will requiring quoting the keys and is more difficult to add tool-level
210-
configuration in the future.
208+
diagnostic messages. This would make it easier to copy/paste lint names.
209+
However, with the schema being `<lint> = <level>`, this would require quoting
210+
the keys rather than leaving them as bare words. This would also cause
211+
problems for tool-level configuration. The first is that the lints wouldn't be
212+
easily grouped with their config. The second is if we use `<lint> = <level>`,
213+
we'd be mixing tool names in with lints, making it easier to conflict and
214+
harder to collect all lints to forward to a tool.
211215

212216
We could possibly extend this new field to `rustfmt` by shifting the focus from
213217
"lints" to "rules" (see

0 commit comments

Comments
 (0)