Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Commit 7f04b38

Browse files
committed
Fix style/clarity for Racer enum
1 parent 17b9962 commit 7f04b38

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

src/actions/hover.rs

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2052,16 +2052,16 @@ pub mod test {
20522052
assert_eq!(expected, actual);
20532053
}
20542054

2055-
enum Racer {
2055+
enum RacerFallback {
20562056
Yes,
20572057
No,
20582058
}
20592059

2060-
impl Into<bool> for Racer {
2061-
fn into(self) -> bool {
2062-
match self {
2063-
Racer::Yes => true,
2064-
Racer::No => false,
2060+
impl From<RacerFallback> for bool {
2061+
fn from(arg: RacerFallback) -> bool {
2062+
match arg {
2063+
RacerFallback::Yes => true,
2064+
RacerFallback::No => false,
20652065
}
20662066
}
20672067
}
@@ -2070,7 +2070,7 @@ pub mod test {
20702070
fn run_tooltip_tests(
20712071
tests: &[Test],
20722072
proj_dir: PathBuf,
2073-
racer_completion: Racer,
2073+
racer_completion: RacerFallback,
20742074
) -> Result<(), Box<dyn std::error::Error>> {
20752075
let out = LineOutput::default();
20762076

@@ -2148,7 +2148,7 @@ pub mod test {
21482148
Test::new("test_tooltip_mod_use.rs", 13, 28),
21492149
];
21502150

2151-
run_tooltip_tests(&tests, FIXTURES_DIR.join("hover"), Racer::No)
2151+
run_tooltip_tests(&tests, FIXTURES_DIR.join("hover"), RacerFallback::No)
21522152
}
21532153

21542154
#[test]
@@ -2163,7 +2163,7 @@ pub mod test {
21632163
Test::new("test_tooltip_mod_use_external.rs", 12, 12),
21642164
];
21652165

2166-
run_tooltip_tests(&tests, FIXTURES_DIR.join("hover"), Racer::Yes)
2166+
run_tooltip_tests(&tests, FIXTURES_DIR.join("hover"), RacerFallback::Yes)
21672167
}
21682168

21692169
/// Note: This test is ignored as it doesn't work in the rust-lang/rust repo.
@@ -2190,7 +2190,7 @@ pub mod test {
21902190
Test::new("test_tooltip_std.rs", 25, 25),
21912191
];
21922192

2193-
run_tooltip_tests(&tests, FIXTURES_DIR.join("hover"), Racer::No)
2193+
run_tooltip_tests(&tests, FIXTURES_DIR.join("hover"), RacerFallback::No)
21942194
}
21952195

21962196
/// Note: This test is ignored as it doesn't work in the rust-lang/rust repo.
@@ -2207,6 +2207,6 @@ pub mod test {
22072207
Test::new("test_tooltip_mod_use_external.rs", 15, 12),
22082208
];
22092209

2210-
run_tooltip_tests(&tests, FIXTURES_DIR.join("hover"), Racer::Yes)
2210+
run_tooltip_tests(&tests, FIXTURES_DIR.join("hover"), RacerFallback::Yes)
22112211
}
22122212
}

0 commit comments

Comments
 (0)