Fix pointer to pointer silliness

jabagawee · jabagawee · commit 98fe1518805b · 2019-03-12T01:59:01.000-07:00
diff --git a/rls-analysis/src/raw.rs b/rls-analysis/src/raw.rs
@@ -158,12 +158,12 @@ fn read_crate_data(path: &Path) -> Option<Analysis> {
 }
 
 #[cfg(feature = "serialize-rustc")]
-fn read_analysis(buf: &String) -> Result<Option<Analysis>, rustc_serialize::json::DecoderError> {
-    ::rustc_serialize::json::decode(&buf)
+fn read_analysis(buf: &str) -> Result<Option<Analysis>, rustc_serialize::json::DecoderError> {
+    ::rustc_serialize::json::decode(buf)
 }
 
 #[cfg(feature = "serialize-serde")]
-fn read_analysis(buf: &String) -> Result<Option<Analysis>, serde_json::Error> {
+fn read_analysis(buf: &str) -> Result<Option<Analysis>, serde_json::Error> {
     ::serde_json::from_str(buf)
 }
 

Original file line number	Diff line number	Diff line change
`@@ -158,12 +158,12 @@ fn read_crate_data(path: &Path) -> Option<Analysis> {`
`158`	`158`	`}`
`159`	`159`
`160`	`160`	`#[cfg(feature = "serialize-rustc")]`
`161`		`-fn read_analysis(buf: &String) -> Result<Option<Analysis>, rustc_serialize::json::DecoderError> {`
`162`		`- ::rustc_serialize::json::decode(&buf)`
	`161`	`+fn read_analysis(buf: &str) -> Result<Option<Analysis>, rustc_serialize::json::DecoderError> {`
	`162`	`+ ::rustc_serialize::json::decode(buf)`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`#[cfg(feature = "serialize-serde")]`
`166`		`-fn read_analysis(buf: &String) -> Result<Option<Analysis>, serde_json::Error> {`
	`166`	`+fn read_analysis(buf: &str) -> Result<Option<Analysis>, serde_json::Error> {`
`167`	`167`	`::serde_json::from_str(buf)`
`168`	`168`	`}`
`169`	`169`