Separate common setup logic for test_tooltip tests

Author: Xanewok

src/actions/hover.rs

@@ -2052,10 +2052,32 @@ pub mod test {
         assert_eq!(expected, actual);
     }
 
+    // Common logic used in `test_tooltip_*` tests below
+    fn run_tooltip_tests(tests: &[Test], proj_dir: PathBuf, racer_completion: bool) -> Result<(), Box<dyn std::error::Error>> {
+        let out = LineOutput::default();
+
+        let save_dir_guard = tempfile::tempdir().unwrap();
+        let save_dir = save_dir_guard.path().to_owned();
+        let load_dir = proj_dir.join("save_data");
+
+        let harness = TooltipTestHarness::new(proj_dir, &out, racer_completion);
+
+        out.reset();
+
+        let failures = harness.run_tests(tests, load_dir, save_dir)?;
+
+        if failures.is_empty() {
+            Ok(())
+        } else {
+            eprintln!("{}\n\n", out.reset().join("\n"));
+            eprintln!("Failures (\x1b[91mexpected\x1b[92mactual\x1b[0m): {:#?}\n\n", failures);
+            Err(format!("{} of {} tooltip tests failed", failures.len(), tests.len()).into())
+        }
+    }
+
     #[test]
     fn test_tooltip() -> Result<(), Box<dyn std::error::Error>> {
         let _ = env_logger::try_init();
-        use self::test::{LineOutput, Test, TooltipTestHarness};
 
         let tests = vec![
             Test::new("test_tooltip_01.rs", 13, 11),
@@ -2105,32 +2127,12 @@ pub mod test {
             Test::new("test_tooltip_mod_use.rs", 13, 28),
         ];
 
-        let out = LineOutput::default();
-        let proj_dir = FIXTURES_DIR.join("hover");
-
-        let save_dir_guard = tempfile::tempdir().unwrap();
-        let save_dir = save_dir_guard.path().to_owned();
-        let load_dir = proj_dir.join("save_data");
-
-        let harness = TooltipTestHarness::new(proj_dir, &out, false);
-
-        out.reset();
-
-        let failures = harness.run_tests(&tests, load_dir, save_dir)?;
-
-        if failures.is_empty() {
-            Ok(())
-        } else {
-            eprintln!("{}\n\n", out.reset().join("\n"));
-            eprintln!("Failures (\x1b[91mexpected\x1b[92mactual\x1b[0m): {:#?}\n\n", failures);
-            Err(format!("{} of {} tooltip tests failed", failures.len(), tests.len()).into())
-        }
+        run_tooltip_tests(&tests, FIXTURES_DIR.join("hover"), false)
     }
 
     #[test]
     fn test_tooltip_racer() -> Result<(), Box<dyn std::error::Error>> {
         let _ = env_logger::try_init();
-        use self::test::{LineOutput, Test, TooltipTestHarness};
 
         let tests = vec![
             Test::new("test_tooltip_01.rs", 80, 11),
@@ -2140,26 +2142,7 @@ pub mod test {
             Test::new("test_tooltip_mod_use_external.rs", 12, 12),
         ];
 
-        let out = LineOutput::default();
-        let proj_dir = FIXTURES_DIR.join("hover");
-
-        let save_dir_guard = tempfile::tempdir().unwrap();
-        let save_dir = save_dir_guard.path().to_owned();
-        let load_dir = proj_dir.join("save_data");
-
-        let harness = TooltipTestHarness::new(proj_dir, &out, true);
-
-        out.reset();
-
-        let failures = harness.run_tests(&tests, load_dir, save_dir)?;
-
-        if failures.is_empty() {
-            Ok(())
-        } else {
-            eprintln!("{}\n\n", out.reset().join("\n"));
-            eprintln!("Failures (\x1b[91mexpected\x1b[92mactual\x1b[0m): {:#?}\n\n", failures);
-            Err(format!("{} of {} tooltip tests failed", failures.len(), tests.len()).into())
-        }
+        run_tooltip_tests(&tests, FIXTURES_DIR.join("hover"), true)
     }
 
     /// Note: This test is ignored as it doesn't work in the rust-lang/rust repo.
@@ -2169,7 +2152,6 @@ pub mod test {
     #[ignore]
     fn test_tooltip_std() -> Result<(), Box<dyn std::error::Error>> {
         let _ = env_logger::try_init();
-        use self::test::{LineOutput, Test, TooltipTestHarness};
 
         let tests = vec![
             Test::new("test_tooltip_std.rs", 18, 15),
@@ -2187,26 +2169,7 @@ pub mod test {
             Test::new("test_tooltip_std.rs", 25, 25),
         ];
 
-        let out = LineOutput::default();
-        let proj_dir = FIXTURES_DIR.join("hover");
-
-        let save_dir_guard = tempfile::tempdir().unwrap();
-        let save_dir = save_dir_guard.path().to_owned();
-        let load_dir = proj_dir.join("save_data");
-
-        let harness = TooltipTestHarness::new(proj_dir, &out, false);
-
-        out.reset();
-
-        let failures = harness.run_tests(&tests, load_dir, save_dir)?;
-
-        if failures.is_empty() {
-            Ok(())
-        } else {
-            eprintln!("{}\n\n", out.reset().join("\n"));
-            eprintln!("Failures (\x1b[91mexpected\x1b[92mactual\x1b[0m): {:#?}\n\n", failures);
-            Err(format!("{} of {} tooltip tests failed", failures.len(), tests.len()).into())
-        }
+        run_tooltip_tests(&tests, FIXTURES_DIR.join("hover"), false)
     }
 
     /// Note: This test is ignored as it doesn't work in the rust-lang/rust repo.
@@ -2216,33 +2179,13 @@ pub mod test {
     #[ignore]
     fn test_tooltip_std_racer() -> Result<(), Box<dyn std::error::Error>> {
         let _ = env_logger::try_init();
-        use self::test::{LineOutput, Test, TooltipTestHarness};
 
         let tests = vec![
             // these test std stuff
             Test::new("test_tooltip_mod_use_external.rs", 14, 12),
             Test::new("test_tooltip_mod_use_external.rs", 15, 12),
         ];
 
-        let out = LineOutput::default();
-        let proj_dir = FIXTURES_DIR.join("hover");
-
-        let save_dir_guard = tempfile::tempdir().unwrap();
-        let save_dir = save_dir_guard.path().to_owned();
-        let load_dir = proj_dir.join("save_data");
-
-        let harness = TooltipTestHarness::new(proj_dir, &out, true);
-
-        out.reset();
-
-        let failures = harness.run_tests(&tests, load_dir, save_dir)?;
-
-        if failures.is_empty() {
-            Ok(())
-        } else {
-            eprintln!("{}\n\n", out.reset().join("\n"));
-            eprintln!("Failures (\x1b[91mexpected\x1b[92mactual\x1b[0m): {:#?}\n\n", failures);
-            Err(format!("{} of {} tooltip tests failed", failures.len(), tests.len()).into())
-        }
+        run_tooltip_tests(&tests, FIXTURES_DIR.join("hover"), true)
     }
 }