Centralize defaults

Author: matklad

crates/ra_flycheck/src/lib.rs

@@ -28,16 +28,6 @@ pub enum FlycheckConfig {
     CustomCommand { command: String, args: Vec<String> },
 }
 
-impl Default for FlycheckConfig {
-    fn default() -> Self {
-        FlycheckConfig::CargoCommand {
-            command: "check".to_string(),
-            all_targets: true,
-            extra_args: Vec::new(),
-        }
-    }
-}
-
 /// Flycheck wraps the shared state and communication machinery used for
 /// running `cargo check` (or other compatible command) and providing
 /// diagnostics based on the output.

crates/rust-analyzer/src/config.rs

@@ -51,12 +51,6 @@ pub enum RustfmtConfig {
     },
 }
 
-impl Default for RustfmtConfig {
-    fn default() -> Self {
-        RustfmtConfig::Rustfmt { extra_args: Vec::new() }
-    }
-}
-
 #[derive(Debug, Clone, Default)]
 pub struct ClientCapsConfig {
     pub location_link: bool,
@@ -85,8 +79,12 @@ impl Default for Config {
                 add_call_argument_snippets: true,
             },
             call_info_full: true,
-            rustfmt: RustfmtConfig::default(),
-            check: Some(FlycheckConfig::default()),
+            rustfmt: RustfmtConfig::Rustfmt { extra_args: Vec::new() },
+            check: Some(FlycheckConfig::CargoCommand {
+                command: "check".to_string(),
+                all_targets: true,
+                extra_args: Vec::new(),
+            }),
             vscode_lldb: false,
             proc_macro_srv: None,
             lru_capacity: None,