Skip to content

Commit 1cef532

Browse files
committed
minor: fixup generate assist priorities
1 parent d03397f commit 1cef532

File tree

3 files changed

+6
-7
lines changed

3 files changed

+6
-7
lines changed

crates/ide_assists/src/handlers/generate_delegate_methods.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,18 +47,18 @@ pub(crate) fn generate_delegate_methods(acc: &mut Assists, ctx: &AssistContext)
4747
let strukt_name = strukt.name()?;
4848
let current_module = ctx.sema.scope(strukt.syntax()).module()?;
4949

50-
let (field_name, field_ty) = match ctx.find_node_at_offset::<ast::RecordField>() {
50+
let (field_name, field_ty, target) = match ctx.find_node_at_offset::<ast::RecordField>() {
5151
Some(field) => {
5252
let field_name = field.name()?;
5353
let field_ty = field.ty()?;
54-
(format!("{}", field_name), field_ty)
54+
(format!("{}", field_name), field_ty, field.syntax().text_range())
5555
}
5656
None => {
5757
let field = ctx.find_node_at_offset::<ast::TupleField>()?;
5858
let field_list = ctx.find_node_at_offset::<ast::TupleFieldList>()?;
5959
let field_list_index = field_list.fields().position(|it| it == field)?;
6060
let field_ty = field.ty()?;
61-
(format!("{}", field_list_index), field_ty)
61+
(format!("{}", field_list_index), field_ty, field.syntax().text_range())
6262
}
6363
};
6464

@@ -74,7 +74,6 @@ pub(crate) fn generate_delegate_methods(acc: &mut Assists, ctx: &AssistContext)
7474
Option::<()>::None
7575
});
7676

77-
let target = field_ty.syntax().text_range();
7877
for method in methods {
7978
let adt = ast::Adt::Struct(strukt.clone());
8079
let name = method.name(ctx.db()).to_string();

crates/ide_assists/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,6 @@ mod handlers {
216216
generate_constant::generate_constant,
217217
generate_default_from_enum_variant::generate_default_from_enum_variant,
218218
generate_default_from_new::generate_default_from_new,
219-
generate_delegate_methods::generate_delegate_methods,
220-
generate_deref::generate_deref,
221219
generate_derive::generate_derive,
222220
generate_enum_is_method::generate_enum_is_method,
223221
generate_enum_projection_method::generate_enum_as_method,
@@ -285,6 +283,8 @@ mod handlers {
285283
generate_getter::generate_getter,
286284
generate_getter::generate_getter_mut,
287285
generate_setter::generate_setter,
286+
generate_delegate_methods::generate_delegate_methods,
287+
generate_deref::generate_deref,
288288
// Are you sure you want to add new assist here, and not to the
289289
// sorted list above?
290290
]

crates/ide_assists/src/tests.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,10 +222,10 @@ fn assist_order_field_struct() {
222222
let mut assists = assists.iter();
223223

224224
assert_eq!(assists.next().expect("expected assist").label, "Change visibility to pub(crate)");
225-
assert_eq!(assists.next().expect("expected assist").label, "Generate `Deref` impl using `bar`");
226225
assert_eq!(assists.next().expect("expected assist").label, "Generate a getter method");
227226
assert_eq!(assists.next().expect("expected assist").label, "Generate a mut getter method");
228227
assert_eq!(assists.next().expect("expected assist").label, "Generate a setter method");
228+
assert_eq!(assists.next().expect("expected assist").label, "Generate `Deref` impl using `bar`");
229229
assert_eq!(assists.next().expect("expected assist").label, "Add `#[derive]`");
230230
}
231231

0 commit comments

Comments
 (0)