Most of the checkOnSafe options now default to the cargo equivalent.

Author: clemenswasser

crates/rust-analyzer/src/config.rs

@@ -241,7 +241,11 @@ impl Config {
                         set(value, "/checkOnSave/extraArgs", extra_args);
                         set(value, "/checkOnSave/command", command);
                         set(value, "/checkOnSave/allTargets", all_targets);
-                        set(value, "/checkOnSave/allFeatures", all_features);
+                        if let Some(new_all_features) = get(value, "/checkOnSave/allFeatures") {
+                            *all_features = new_all_features;
+                        } else {
+                            *all_features = self.cargo.all_features;
+                        }
                         set(value, "/checkOnSave/features", features);
                         if features.is_empty() && !self.cargo.features.is_empty() {
                             *features = self.cargo.features.clone();

editors/code/package.json

@@ -318,17 +318,20 @@
                     "markdownDescription": "Check all targets and tests (will be passed as `--all-targets`)"
                 },
                 "rust-analyzer.checkOnSave.allFeatures": {
-                    "type": "boolean",
-                    "default": false,
-                    "markdownDescription": "Check with all features (will be passed as `--all-features`)"
+                    "type": [
+                        "null",
+                        "boolean"
+                    ],
+                    "default": null,
+                    "markdownDescription": "Check with all features (will be passed as `--all-features`). Defaults to `rust-analyzer.cargo.allFeatures`."
                 },
                 "rust-analyzer.checkOnSave.features": {
                     "type": "array",
                     "items": {
                         "type": "string"
                     },
                     "default": [],
-                    "description": "List of features to activate. Set to `rust-analyzer.cargo.features` if empty."
+                    "description": "List of features to activate. Defaults to `rust-analyzer.cargo.features`."
                 },
                 "rust-analyzer.inlayHints.enable": {
                     "type": "boolean",