Merge #5560

5560: Fix nameref parsing r=matklad a=matklad



bors r+
🤖

Co-authored-by: Aleksey Kladov <[email protected]>

Author: bors[bot]

crates/ra_parser/src/grammar.rs

@@ -270,10 +270,6 @@ fn name_ref(p: &mut Parser) {
         let m = p.start();
         p.bump(IDENT);
         m.complete(p, NAME_REF);
-    } else if p.at(T![self]) {
-        let m = p.start();
-        p.bump(T![self]);
-        m.complete(p, T![self]);
     } else {
         p.err_and_bump("expected identifier");
     }

crates/ra_parser/src/grammar/items.rs

@@ -304,7 +304,13 @@ fn extern_crate_item(p: &mut Parser, m: Marker) {
     p.bump(T![extern]);
     assert!(p.at(T![crate]));
     p.bump(T![crate]);
-    name_ref(p);
+
+    if p.at(T![self]) {
+        p.bump(T![self]);
+    } else {
+        name_ref(p);
+    }
+
     opt_alias(p);
     p.expect(T![;]);
     m.complete(p, EXTERN_CRATE_ITEM);

crates/ra_syntax/test_data/parser/ok/0007_extern_crate.rast

@@ -28,8 +28,7 @@ [email protected]
     [email protected] " "
     [email protected] "crate"
     [email protected] " "
-    [email protected]
-      [email protected] "self"
+    [email protected] "self"
     [email protected] " "
     [email protected]
       [email protected] "as"