Reduce allocation in builtin_crates

lhvy · Veykril · web-flow · commit 6606b497102b · 2021-10-01T01:56:30.000+10:00
Co-authored-by: Lukas Wirth &lt;lukastw97@gmail.com&gt;
diff --git a/crates/ide_db/src/helpers/famous_defs.rs b/crates/ide_db/src/helpers/famous_defs.rs
@@ -80,7 +80,7 @@ impl FamousDefs<'_, '_> {
         self.find_crate("proc_macro")
     }
 
-    pub fn builtin_crates(&self) -> Vec<Crate> {
+    pub fn builtin_crates(&self) -> impl Iterator<Item = Crate> {
         IntoIterator::into_iter([
             self.std(),
             self.core(),
@@ -89,7 +89,6 @@ impl FamousDefs<'_, '_> {
             self.proc_macro(),
         ])
         .filter_map(|it| it)
-        .collect()
     }
 
     fn find_trait(&self, path: &str) -> Option<Trait> {

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ impl FamousDefs<'_, '_> {`
`80`	`80`	`self.find_crate("proc_macro")`
`81`	`81`	`}`
`82`	`82`
`83`		`- pub fn builtin_crates(&self) -> Vec<Crate> {`
	`83`	`+ pub fn builtin_crates(&self) -> impl Iterator<Item = Crate> {`
`84`	`84`	`IntoIterator::into_iter([`
`85`	`85`	`self.std(),`
`86`	`86`	`self.core(),`
`@@ -89,7 +89,6 @@ impl FamousDefs<'_, '_> {`
`89`	`89`	`self.proc_macro(),`
`90`	`90`	`])`
`91`	`91`	`.filter_map(\|it\| it)`
`92`		`- .collect()`
`93`	`92`	`}`
`94`	`93`
`95`	`94`	`fn find_trait(&self, path: &str) -> Option<Trait> {`