Prepare to recompute completions on every keystroke

matklad · matklad · commit 682dd4dac0cf · 2020-11-16T17:27:36.000+01:00
If we set `is_incomplete: true`, VS Code will re-query completions
after every keypress.
diff --git a/crates/rust-analyzer/src/handlers.rs b/crates/rust-analyzer/src/handlers.rs
@@ -573,7 +573,8 @@ pub(crate) fn handle_completion(
         .flat_map(|item| to_proto::completion_item(&line_index, line_endings, item))
         .collect();
 
-    Ok(Some(items.into()))
+    let completion_list = lsp_types::CompletionList { is_incomplete: false, items };
+    Ok(Some(completion_list.into()))
 }
 
 pub(crate) fn handle_folding_range(

Original file line number	Diff line number	Diff line change
`@@ -573,7 +573,8 @@ pub(crate) fn handle_completion(`
`573`	`573`	`.flat_map(\|item\| to_proto::completion_item(&line_index, line_endings, item))`
`574`	`574`	`.collect();`
`575`	`575`
`576`		`- Ok(Some(items.into()))`
	`576`	`+ let completion_list = lsp_types::CompletionList { is_incomplete: false, items };`
	`577`	`+ Ok(Some(completion_list.into()))`
`577`	`578`	`}`
`578`	`579`
`579`	`580`	`pub(crate) fn handle_folding_range(`