vscode: rename alwaysDownloadServer -> askBeforeDownload

The new name seems much simpler and it doesn't limit
this config value only to downloading the server binary.
Thus we wouldn't need to create another config
properties to handle other downloads whatsoever.
Anyway, I believe (heuristically) that most of the users
would want to set "askBeforeDownload": false once
and never bother clicking on the notification again
(because otherwise there is no big point in installing rust-analyzer if it cannot install the server)

Author: Veetaha

docs/user/readme.adoc

@@ -43,7 +43,7 @@ image::https://user-images.githubusercontent.com/9021944/75067008-17502500-54ba-
 > Note: to disable this notification put the following to `settings.json`
 > ```json
 {
-    "rust-analyzer.alwaysDownloadServer": true
+    "rust-analyzer.askBeforeDownload": false
 }
 ```
 

editors/code/package.json

@@ -219,10 +219,10 @@
                         }
                     }
                 },
-                "rust-analyzer.alwaysDownloadServer": {
+                "rust-analyzer.askBeforeDownload": {
                     "type": "boolean",
-                    "default": false,
-                    "description": "Whether to ask before downloading the language server binary"
+                    "default": true,
+                    "description": "Whether to ask for permission before downloading any files from the Internet"
                 },
                 "rust-analyzer.serverPath": {
                     "type": [

editors/code/src/config.ts

@@ -134,7 +134,7 @@ export class Config {
             file: prebuiltBinaryName,
             storage: this.ctx.globalState,
             tag: Config.extensionVersion,
-            askBeforeDownload: !(this.cfg.get("alwaysDownloadServer") as boolean),
+            askBeforeDownload: !(this.cfg.get("askBeforeDownload") as boolean),
             repo: {
                 name: "rust-analyzer",
                 owner: "rust-analyzer",