Merge #4675

bors[bot] · Veetaha · web-flow · commit 7ae247f03c63 · 2020-05-31T21:09:24.000Z
4675: Small refactor r=kiljacken a=Veetaha



Co-authored-by: veetaha &lt;veetaha2@gmail.com&gt;
diff --git a/crates/ra_syntax/src/syntax_node.rs b/crates/ra_syntax/src/syntax_node.rs
@@ -48,11 +48,11 @@ impl SyntaxTreeBuilder {
 
     pub fn finish(self) -> Parse<SyntaxNode> {
         let (green, errors) = self.finish_raw();
-        let node = SyntaxNode::new_root(green);
         if cfg!(debug_assertions) {
+            let node = SyntaxNode::new_root(green.clone());
             crate::validation::validate_block_structure(&node);
         }
-        Parse::new(node.green().clone(), errors)
+        Parse::new(green, errors)
     }
 
     pub fn token(&mut self, kind: SyntaxKind, text: SmolStr) {

Original file line number	Diff line number	Diff line change
`@@ -48,11 +48,11 @@ impl SyntaxTreeBuilder {`
`48`	`48`
`49`	`49`	`pub fn finish(self) -> Parse<SyntaxNode> {`
`50`	`50`	`let (green, errors) = self.finish_raw();`
`51`		`- let node = SyntaxNode::new_root(green);`
`52`	`51`	`if cfg!(debug_assertions) {`
	`52`	`+ let node = SyntaxNode::new_root(green.clone());`
`53`	`53`	`crate::validation::validate_block_structure(&node);`
`54`	`54`	`}`
`55`		`- Parse::new(node.green().clone(), errors)`
	`55`	`+ Parse::new(green, errors)`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`pub fn token(&mut self, kind: SyntaxKind, text: SmolStr) {`