.clone() over .to_owned()

Vannevelj · Vannevelj · commit 8c0b848694a5 · 2022-01-05T21:10:03.000Z
diff --git a/crates/ide_assists/src/handlers/extract_variable.rs b/crates/ide_assists/src/handlers/extract_variable.rs
@@ -161,7 +161,7 @@ fn valid_target_expr(node: SyntaxNode) -> Option<ast::Expr> {
 }
 
 fn get_receiver_type(ctx: &AssistContext, expression: &ast::Expr) -> Option<hir::Type> {
-    let receiver = get_receiver(expression.to_owned())?;
+    let receiver = get_receiver(expression.clone())?;
     Some(ctx.sema.type_of_expr(&receiver)?.original())
 }
 

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ fn valid_target_expr(node: SyntaxNode) -> Option<ast::Expr> {`
`161`	`161`	`}`
`162`	`162`
`163`	`163`	`fn get_receiver_type(ctx: &AssistContext, expression: &ast::Expr) -> Option<hir::Type> {`
`164`		`- let receiver = get_receiver(expression.to_owned())?;`
	`164`	`+ let receiver = get_receiver(expression.clone())?;`
`165`	`165`	`Some(ctx.sema.type_of_expr(&receiver)?.original())`
`166`	`166`	`}`
`167`	`167`