Skip to content

Commit 9a3bb19

Browse files
Remove fixed FIXME, propagate errors better
1 parent e2d8e11 commit 9a3bb19

File tree

1 file changed

+2
-6
lines changed
  • crates/hir_expand/src

1 file changed

+2
-6
lines changed

crates/hir_expand/src/db.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -359,11 +359,7 @@ pub fn parse_macro_with_arg(
359359

360360
match result.error {
361361
Some(error) => {
362-
// FIXME:
363-
// In future, we should propagate the actual error with recovery information
364-
// instead of ignore the error here.
365-
366-
// Safe check for recurisve identity macro
362+
// Safety check for recursive identity macro.
367363
let node = parse.syntax_node();
368364
let file: HirFileId = macro_file.into();
369365
let call_node = match file.call_node(db) {
@@ -374,7 +370,7 @@ pub fn parse_macro_with_arg(
374370
};
375371

376372
if !diff(&node, &call_node.value).is_empty() {
377-
MacroResult { value: Some((parse, Arc::new(rev_token_map))), error: None }
373+
MacroResult { value: Some((parse, Arc::new(rev_token_map))), error: Some(error) }
378374
} else {
379375
return MacroResult::error(error);
380376
}

0 commit comments

Comments
 (0)