Skip to content

Commit b090ee5

Browse files
bors[bot]matklad
andauthored
Merge #3003
3003: Remove rollup-typescript r=matklad a=matklad It seems like just calling typescript directly is simpler and more reliable? @Veetaha what do you think about this approach? Co-authored-by: Aleksey Kladov <[email protected]>
2 parents 8d18b15 + f0323de commit b090ee5

File tree

3 files changed

+3
-16
lines changed

3 files changed

+3
-16
lines changed

editors/code/package-lock.json

Lines changed: 0 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

editors/code/package.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,9 @@
1818
"vscode": "^1.41.0"
1919
},
2020
"scripts": {
21-
"vscode:prepublish": "rollup -c",
21+
"vscode:prepublish": "tsc && rollup -c",
2222
"package": "vsce package",
23-
"watch": "tsc -watch -p ./",
23+
"watch": "tsc --watch",
2424
"fmt": "tsfmt -r && tslint -c tslint.json 'src/**/*.ts' --fix"
2525
},
2626
"dependencies": {
@@ -30,7 +30,6 @@
3030
"devDependencies": {
3131
"@rollup/plugin-commonjs": "^11.0.2",
3232
"@rollup/plugin-node-resolve": "^7.1.1",
33-
"@rollup/plugin-typescript": "^2.0.0",
3433
"@types/node": "^12.12.25",
3534
"@types/vscode": "^1.41.0",
3635
"rollup": "^1.31.0",

editors/code/rollup.config.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
1-
import typescript from '@rollup/plugin-typescript';
21
import resolve from '@rollup/plugin-node-resolve';
32
import commonjs from '@rollup/plugin-commonjs';
43
import nodeBuiltins from 'builtin-modules';
54

65
export default {
7-
input: 'src/main.ts',
6+
input: 'out/main.js',
87
plugins: [
9-
typescript(),
108
resolve({
119
preferBuiltins: true
1210
}),

0 commit comments

Comments
 (0)