Add AssistKind::Generate

Author: matklad

crates/ra_assists/src/handlers/generate_derive.rs

@@ -29,27 +29,32 @@ pub(crate) fn generate_derive(acc: &mut Assists, ctx: &AssistContext) -> Option<
     let nominal = ctx.find_node_at_offset::<ast::NominalDef>()?;
     let node_start = derive_insertion_offset(&nominal)?;
     let target = nominal.syntax().text_range();
-    acc.add(AssistId("generate_derive", AssistKind::None), "Add `#[derive]`", target, |builder| {
-        let derive_attr = nominal
-            .attrs()
-            .filter_map(|x| x.as_simple_call())
-            .filter(|(name, _arg)| name == "derive")
-            .map(|(_name, arg)| arg)
-            .next();
-        match derive_attr {
-            None => {
-                builder.insert_snippet(cap, node_start, "#[derive($0)]\n");
-            }
-            Some(tt) => {
-                // Just move the cursor.
-                builder.insert_snippet(
-                    cap,
-                    tt.syntax().text_range().end() - TextSize::of(')'),
-                    "$0",
-                )
-            }
-        };
-    })
+    acc.add(
+        AssistId("generate_derive", AssistKind::Generate),
+        "Add `#[derive]`",
+        target,
+        |builder| {
+            let derive_attr = nominal
+                .attrs()
+                .filter_map(|x| x.as_simple_call())
+                .filter(|(name, _arg)| name == "derive")
+                .map(|(_name, arg)| arg)
+                .next();
+            match derive_attr {
+                None => {
+                    builder.insert_snippet(cap, node_start, "#[derive($0)]\n");
+                }
+                Some(tt) => {
+                    // Just move the cursor.
+                    builder.insert_snippet(
+                        cap,
+                        tt.syntax().text_range().end() - TextSize::of(')'),
+                        "$0",
+                    )
+                }
+            };
+        },
+    )
 }
 
 // Insert `derive` after doc comments.

crates/ra_assists/src/handlers/generate_from_impl_for_enum.rs

@@ -45,7 +45,7 @@ pub(crate) fn generate_from_impl_for_enum(acc: &mut Assists, ctx: &AssistContext
 
     let target = variant.syntax().text_range();
     acc.add(
-        AssistId("generate_from_impl_for_enum", AssistKind::Refactor),
+        AssistId("generate_from_impl_for_enum", AssistKind::Generate),
         "Generate `From` impl for this enum variant",
         target,
         |edit| {

crates/ra_assists/src/handlers/generate_function.rs

@@ -63,7 +63,7 @@ pub(crate) fn generate_function(acc: &mut Assists, ctx: &AssistContext) -> Optio
 
     let target = call.syntax().text_range();
     acc.add(
-        AssistId("generate_function", AssistKind::None),
+        AssistId("generate_function", AssistKind::Generate),
         format!("Generate `{}` function", function_builder.fn_name),
         target,
         |builder| {

crates/ra_assists/src/handlers/generate_impl.rs

@@ -27,7 +27,7 @@ pub(crate) fn generate_impl(acc: &mut Assists, ctx: &AssistContext) -> Option<()
     let name = nominal.name()?;
     let target = nominal.syntax().text_range();
     acc.add(
-        AssistId("generate_impl", AssistKind::Refactor),
+        AssistId("generate_impl", AssistKind::Generate),
         format!("Generate impl for `{}`", name),
         target,
         |edit| {

crates/ra_assists/src/handlers/generate_new.rs

@@ -42,7 +42,7 @@ pub(crate) fn generate_new(acc: &mut Assists, ctx: &AssistContext) -> Option<()>
     let impl_def = find_struct_impl(&ctx, &strukt)?;
 
     let target = strukt.syntax().text_range();
-    acc.add(AssistId("generate_new", AssistKind::None), "Generate `new`", target, |builder| {
+    acc.add(AssistId("generate_new", AssistKind::Generate), "Generate `new`", target, |builder| {
         let mut buf = String::with_capacity(512);
 
         if impl_def.is_some() {

crates/ra_assists/src/lib.rs

@@ -30,6 +30,7 @@ pub use assist_config::AssistConfig;
 pub enum AssistKind {
     None,
     QuickFix,
+    Generate,
     Refactor,
     RefactorExtract,
     RefactorInline,

crates/rust-analyzer/src/to_proto.rs

@@ -629,7 +629,7 @@ pub(crate) fn call_hierarchy_item(
 
 pub(crate) fn code_action_kind(kind: AssistKind) -> String {
     match kind {
-        AssistKind::None => lsp_types::code_action_kind::EMPTY,
+        AssistKind::None | AssistKind::Generate => lsp_types::code_action_kind::EMPTY,
         AssistKind::QuickFix => lsp_types::code_action_kind::QUICKFIX,
         AssistKind::Refactor => lsp_types::code_action_kind::REFACTOR,
         AssistKind::RefactorExtract => lsp_types::code_action_kind::REFACTOR_EXTRACT,