Skip to content

Commit de7662c

Browse files
committed
Check that no file contains trailing ws
rustfmt allows trailing spaces in string literals unfortunately.
1 parent 089c554 commit de7662c

File tree

6 files changed

+142
-127
lines changed

6 files changed

+142
-127
lines changed

crates/ra_hir_def/src/nameres/tests.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ use test_utils::covers;
1212

1313
use crate::{db::DefDatabase, nameres::*, test_db::TestDB};
1414

15-
fn def_map(fixture: &str) -> String {
16-
compute_crate_def_map(fixture).dump()
15+
fn def_map(ra_fixture: &str) -> String {
16+
compute_crate_def_map(ra_fixture).dump()
1717
}
1818

1919
fn compute_crate_def_map(fixture: &str) -> Arc<CrateDefMap> {

crates/ra_hir_def/src/nameres/tests/globs.rs

Lines changed: 46 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use super::*;
33
#[test]
44
fn glob_1() {
55
let map = def_map(
6-
"
6+
r"
77
//- /lib.rs
88
mod foo;
99
use foo::*;
@@ -76,7 +76,7 @@ fn glob_2() {
7676
#[test]
7777
fn glob_privacy_1() {
7878
let map = def_map(
79-
"
79+
r"
8080
//- /lib.rs
8181
mod foo;
8282
use foo::*;
@@ -93,29 +93,29 @@ fn glob_privacy_1() {
9393
",
9494
);
9595
assert_snapshot!(map, @r###"
96-
crate
97-
Baz: t v
98-
bar: t
99-
foo: t
100-
101-
crate::foo
102-
Baz: t v
103-
PrivateStructFoo: t v
104-
bar: t
105-
106-
crate::foo::bar
107-
Baz: t v
108-
PrivateStructBar: t v
109-
PrivateStructFoo: t v
110-
bar: t
96+
crate
97+
Baz: t v
98+
bar: t
99+
foo: t
100+
101+
crate::foo
102+
Baz: t v
103+
PrivateStructFoo: t v
104+
bar: t
105+
106+
crate::foo::bar
107+
Baz: t v
108+
PrivateStructBar: t v
109+
PrivateStructFoo: t v
110+
bar: t
111111
"###
112112
);
113113
}
114114

115115
#[test]
116116
fn glob_privacy_2() {
117117
let map = def_map(
118-
"
118+
r"
119119
//- /lib.rs
120120
mod foo;
121121
use foo::*;
@@ -133,19 +133,19 @@ fn glob_privacy_2() {
133133
",
134134
);
135135
assert_snapshot!(map, @r###"
136-
crate
137-
Foo: t
138-
PubCrateStruct: t v
139-
foo: t
140-
141-
crate::foo
142-
Foo: t v
143-
bar: t
144-
145-
crate::foo::bar
146-
PrivateBar: t v
147-
PrivateBaz: t v
148-
PubCrateStruct: t v
136+
crate
137+
Foo: t
138+
PubCrateStruct: t v
139+
foo: t
140+
141+
crate::foo
142+
Foo: t v
143+
bar: t
144+
145+
crate::foo::bar
146+
PrivateBar: t v
147+
PrivateBaz: t v
148+
PubCrateStruct: t v
149149
"###
150150
);
151151
}
@@ -154,7 +154,7 @@ fn glob_privacy_2() {
154154
fn glob_across_crates() {
155155
covers!(glob_across_crates);
156156
let map = def_map(
157-
"
157+
r"
158158
//- /main.rs crate:main deps:test_crate
159159
use test_crate::*;
160160
@@ -163,8 +163,8 @@ fn glob_across_crates() {
163163
",
164164
);
165165
assert_snapshot!(map, @r###"
166-
⋮crate
167-
⋮Baz: t v
166+
⋮crate
167+
⋮Baz: t v
168168
"###
169169
);
170170
}
@@ -173,7 +173,7 @@ fn glob_across_crates() {
173173
fn glob_privacy_across_crates() {
174174
covers!(glob_across_crates);
175175
let map = def_map(
176-
"
176+
r"
177177
//- /main.rs crate:main deps:test_crate
178178
use test_crate::*;
179179
@@ -183,8 +183,8 @@ fn glob_privacy_across_crates() {
183183
",
184184
);
185185
assert_snapshot!(map, @r###"
186-
⋮crate
187-
⋮Baz: t v
186+
⋮crate
187+
⋮Baz: t v
188188
"###
189189
);
190190
}
@@ -202,10 +202,10 @@ fn glob_enum() {
202202
",
203203
);
204204
assert_snapshot!(map, @r###"
205-
⋮crate
206-
⋮Bar: t v
207-
⋮Baz: t v
208-
⋮Foo: t
205+
⋮crate
206+
⋮Bar: t v
207+
⋮Baz: t v
208+
⋮Foo: t
209209
"###
210210
);
211211
}
@@ -214,7 +214,7 @@ fn glob_enum() {
214214
fn glob_enum_group() {
215215
covers!(glob_enum_group);
216216
let map = def_map(
217-
"
217+
r"
218218
//- /lib.rs
219219
enum Foo {
220220
Bar, Baz
@@ -223,10 +223,10 @@ fn glob_enum_group() {
223223
",
224224
);
225225
assert_snapshot!(map, @r###"
226-
⋮crate
227-
⋮Bar: t v
228-
⋮Baz: t v
229-
⋮Foo: t
226+
⋮crate
227+
⋮Bar: t v
228+
⋮Baz: t v
229+
⋮Foo: t
230230
"###
231231
);
232232
}

crates/ra_hir_def/src/nameres/tests/macros.rs

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use super::*;
33
#[test]
44
fn macro_rules_are_globally_visible() {
55
let map = def_map(
6-
"
6+
r"
77
//- /lib.rs
88
macro_rules! structs {
99
($($i:ident),*) => {
@@ -31,7 +31,7 @@ fn macro_rules_are_globally_visible() {
3131
#[test]
3232
fn macro_rules_can_define_modules() {
3333
let map = def_map(
34-
"
34+
r"
3535
//- /lib.rs
3636
macro_rules! m {
3737
($name:ident) => { mod $name; }
@@ -51,21 +51,21 @@ fn macro_rules_can_define_modules() {
5151
",
5252
);
5353
assert_snapshot!(map, @r###"
54-
crate
55-
m: t
56-
n1: t
57-
58-
crate::m
59-
n3: t
60-
61-
crate::m::n3
62-
Y: t v
63-
64-
crate::n1
65-
n2: t
66-
67-
crate::n1::n2
68-
X: t v
54+
crate
55+
m: t
56+
n1: t
57+
58+
crate::m
59+
n3: t
60+
61+
crate::m::n3
62+
Y: t v
63+
64+
crate::n1
65+
n2: t
66+
67+
crate::n1::n2
68+
X: t v
6969
"###);
7070
}
7171

crates/ra_hir_def/src/nameres/tests/mod_resolution.rs

Lines changed: 42 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use super::*;
44
fn name_res_works_for_broken_modules() {
55
covers!(name_res_works_for_broken_modules);
66
let map = def_map(
7-
"
7+
r"
88
//- /lib.rs
99
mod foo // no `;`, no body
1010
@@ -28,7 +28,7 @@ fn name_res_works_for_broken_modules() {
2828
#[test]
2929
fn nested_module_resolution() {
3030
let map = def_map(
31-
"
31+
r"
3232
//- /lib.rs
3333
mod n1;
3434
@@ -55,7 +55,7 @@ fn nested_module_resolution() {
5555
#[test]
5656
fn nested_module_resolution_2() {
5757
let map = def_map(
58-
"
58+
r"
5959
//- /lib.rs
6060
mod prelude;
6161
mod iter;
@@ -77,23 +77,23 @@ fn nested_module_resolution_2() {
7777
);
7878

7979
assert_snapshot!(map, @r###"
80-
crate
81-
iter: t
82-
prelude: t
83-
84-
crate::iter
85-
Iterator: t
86-
traits: t
87-
88-
crate::iter::traits
89-
Iterator: t
90-
iterator: t
91-
92-
crate::iter::traits::iterator
93-
Iterator: t
94-
95-
crate::prelude
96-
Iterator: t
80+
crate
81+
iter: t
82+
prelude: t
83+
84+
crate::iter
85+
Iterator: t
86+
traits: t
87+
88+
crate::iter::traits
89+
Iterator: t
90+
iterator: t
91+
92+
crate::iter::traits::iterator
93+
Iterator: t
94+
95+
crate::prelude
96+
Iterator: t
9797
"###);
9898
}
9999

@@ -780,17 +780,17 @@ fn nested_out_of_line_module() {
780780
);
781781

782782
assert_snapshot!(map, @r###"
783-
crate
784-
a: t
785-
786-
crate::a
787-
b: t
788-
789-
crate::a::b
790-
c: t
791-
792-
crate::a::b::c
793-
X: t v
783+
crate
784+
a: t
785+
786+
crate::a
787+
b: t
788+
789+
crate::a::b
790+
c: t
791+
792+
crate::a::b::c
793+
X: t v
794794
"###);
795795
}
796796

@@ -812,16 +812,16 @@ fn nested_out_of_line_module_with_path() {
812812
);
813813

814814
assert_snapshot!(map, @r###"
815-
crate
816-
a: t
817-
818-
crate::a
819-
b: t
820-
821-
crate::a::b
822-
c: t
823-
824-
crate::a::b::c
825-
X: t v
815+
crate
816+
a: t
817+
818+
crate::a
819+
b: t
820+
821+
crate::a::b
822+
c: t
823+
824+
crate::a::b::c
825+
X: t v
826826
"###);
827827
}

crates/ra_ide/src/goto_definition.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,8 +100,8 @@ mod tests {
100100

101101
use crate::mock_analysis::analysis_and_position;
102102

103-
fn check_goto(fixture: &str, expected: &str, expected_range: &str) {
104-
let (analysis, pos) = analysis_and_position(fixture);
103+
fn check_goto(ra_fixture: &str, expected: &str, expected_range: &str) {
104+
let (analysis, pos) = analysis_and_position(ra_fixture);
105105

106106
let mut navs = analysis.goto_definition(pos).unwrap().unwrap().info;
107107
assert_eq!(navs.len(), 1);
@@ -790,8 +790,8 @@ mod tests {
790790
#[test]
791791
fn goto_def_in_local_macro() {
792792
check_goto(
793-
"
794-
//- /lib.rs
793+
r"
794+
//- /lib.rs
795795
fn bar() {
796796
macro_rules! foo { () => { () } }
797797
<|>foo!();

0 commit comments

Comments
 (0)