fix: project json runnable kind bin substitution

fixes a bug related to substitution in project json bin not correctly
replacing the `{label}` tag with the label of the current item.

Author: TroyKomodo

crates/ide/src/runnables.rs

@@ -43,15 +43,21 @@ pub enum TestId {
     Path(String),
 }
 
-impl fmt::Display for TestId {
-    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+impl AsRef<str> for TestId {
+    fn as_ref(&self) -> &str {
         match self {
-            TestId::Name(name) => name.fmt(f),
-            TestId::Path(path) => path.fmt(f),
+            Self::Name(n) => &n,
+            Self::Path(p) => &p,
         }
     }
 }
 
+impl fmt::Display for TestId {
+    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
+        f.write_str(self.as_ref())
+    }
+}
+
 #[derive(Debug, Clone, Hash, PartialEq, Eq)]
 pub enum RunnableKind {
     TestMod { path: String },

crates/rust-analyzer/src/target_spec.rs

@@ -70,34 +70,32 @@ pub(crate) struct ProjectJsonTargetSpec {
 impl ProjectJsonTargetSpec {
     pub(crate) fn runnable_args(&self, kind: &RunnableKind) -> Option<Runnable> {
         match kind {
-            RunnableKind::Bin => {
-                for runnable in &self.shell_runnables {
-                    if matches!(runnable.kind, project_model::project_json::RunnableKind::Run) {
-                        return Some(runnable.clone());
-                    }
-                }
-
-                None
-            }
-            RunnableKind::Test { test_id, .. } => {
-                for runnable in &self.shell_runnables {
-                    if matches!(runnable.kind, project_model::project_json::RunnableKind::TestOne) {
-                        let mut runnable = runnable.clone();
-
-                        let replaced_args: Vec<_> = runnable
-                            .args
-                            .iter()
-                            .map(|arg| arg.replace("{test_id}", &test_id.to_string()))
-                            .map(|arg| arg.replace("{label}", &self.label))
-                            .collect();
-                        runnable.args = replaced_args;
-
-                        return Some(runnable);
-                    }
-                }
-
-                None
-            }
+            RunnableKind::Bin => self
+                .shell_runnables
+                .iter()
+                .find(|r| matches!(r.kind, project_model::project_json::RunnableKind::Run))
+                .cloned()
+                .map(|mut runnable| {
+                    runnable.args.iter_mut().for_each(|arg| {
+                        *arg = arg.replace("{label}", &self.label);
+                    });
+
+                    runnable
+                }),
+            RunnableKind::Test { test_id, .. } => self
+                .shell_runnables
+                .iter()
+                .find(|r| matches!(r.kind, project_model::project_json::RunnableKind::TestOne))
+                .cloned()
+                .map(|mut runnable| {
+                    runnable.args.iter_mut().for_each(|arg| {
+                        *arg = arg
+                            .replace("{label}", &self.label)
+                            .replace("{test_id}", test_id.as_ref());
+                    });
+
+                    runnable
+                }),
             RunnableKind::TestMod { .. } => None,
             RunnableKind::Bench { .. } => None,
             RunnableKind::DocTest { .. } => None,