Add pipe to `autoClosingPairs`

[unusual-thoughts]

I keep finding myself expecting the | token to auto-close in VS code when writing closures, as it does with brackets, parentheses etc.

It is especially grating because as long as the closing pipe is dangling, syntax doesn't parse at all and editor output can be flooded with transient errors.

As noted in #11192 , the potential downside is for bitwise OR (and match pattern unions), but I would argue that is much less common and offset by the IMO much bigger benefit with respect to closures. Surprisingly, | was previously in surroundingPairs (causing undesired behavior) but never in autoClosingPairs.

As for (lazy) logical ORs, if you press pipe twice you will get the same thing, so there is no downside.

[unusual-thoughts]

I also wonder whether | should be added to rust-analyzer.typing.triggerChars in

rust-analyzer/editors/code/package.json

Line 2812 in dd41cda

"default": "=.",

This should trigger #18628 which, If I understand correctly, should autoclose lambda parameter lists?

rust-analyzer/crates/ide/src/typing.rs

Lines 393 to 403 in dd41cda

	fn on_pipe_typed(file: &SourceFile, offset: TextSize) -> Option<TextEdit> {
	let pipe_token = file.syntax().token_at_offset(offset).right_biased()?;
	if pipe_token.kind() != SyntaxKind::PIPE {
	return None;
	}
	if pipe_token.parent().and_then(ast::ParamList::cast)?.r_paren_token().is_some() {
	return None;
	}
	let after_lpipe = offset + TextSize::of('|');
	Some(TextEdit::insert(after_lpipe, "|".to_owned()))
	}

However enabling it had no effect in my environment

[Veykril]

Quoting my reply from #19683:

As discussed in that issue, this kind of auto closing pair is very context dependent. Turning a | b into a || b will be very frustrating for people, especially those that write a lot of bit operations, causing the IDE to actively work against them. As such this is unfortunately not a change we can make.

As for the typing handler. We used to have it enabled by default for | but the typing handler for that is currently kind of broken #18641

[Veykril]

Closing as per my last comment, the only relevant part here is #18641