Request to review some old PRs

[A4-Tacks]

I have open too many PRs, causing some old PRs to seem forgotten

The following PRs are more worth merging first

• Fix not complete after inner-attr in source-file #20976 Fix not complete after inner-attr in source-file
• Add multiple generate for enum generate is, as, try_into #20685 Add multiple generate for enum generate is, as, try_into
• Fix syntax_editor duplicated changed element #21023 Fix syntax_editor duplicated changed element
• Fix not complete type alias in pattern #21028 Fix not complete type alias in pattern
• Implement thin-arrow completion in fn return position #21012 Implement thin-arrow completion in fn return position
• fix: fix field completion in irrefutable patterns #21065 Fix always irrefutable in RecordPatField
• Add macro segment completion #20741 Add macro segment completion

Fixes pull requests

• Fix generic param for generate_default_from_enum_variant #20362 Fix generic param for generate_default_from_enum_variant
• Fix nested if-let for merge_nested_if #20576 Fix nested if-let for merge_nested_if
• Fix indent for merge_nested_if #20577 Fix indent for merge_nested_if
• Fix indent for convert_closure_to_fn #20594 Fix indent for convert_closure_to_fn
• Fix indent for convert_iter_for_each_to_for #20595 Fix indent for convert_iter_for_each_to_for
• Fix not applicable on empty struct for no_such_field #20614 Fix not applicable on empty struct for no_such_field
• Fix indent for trait_impl_redundant_assoc_item #20681 Fix indent for trait_impl_redundant_assoc_item
• Fix loses label for convert_for_to_while_let #20754 Fix loses label for convert_for_to_while_let
• Fix range expr expected type suggest #20933 Fix range expr expected type suggest
• Fix duplicate const complete after raw #20937 Fix duplicate const complete after raw
• Fix not applicable on statement for convert_to_guarded_return #20946 Fix not applicable on statement for convert_to_guarded_return
• Fix not complete after inner-attr in source-file #20976 Fix not complete after inner-attr in source-file
• Fix syntax_editor duplicated changed element #21023 Fix syntax_editor duplicated changed element
• Fix not complete type alias in pattern #21028 Fix not complete type alias in pattern

Improve pull requests

• Add partial selection for generate_getter_or_setter #20353 Add partial selection for generate_getter_or_setter
• Fix guess renamed macro braces #20438 Fix guess renamed macro braces
• Add guess braces doc T![] for T_ #20439 Add guess braces doc T![] for T_
• Add convert unwrap_or_else for convert_bool_then #20508 Add convert unwrap_or_else for convert_bool_then
• Add BreakExpr completion suggest #20521 Add BreakExpr completion suggest
• Add pretty number for add_explicit_enum_discriminant #20559 Add pretty number for add_explicit_enum_discriminant
• Add ReturnExpr support for add_return_type #20564 Add ReturnExpr support for add_return_type
• Add partial selection for merge_imports #20566 Add partial selection for merge_imports
• Add LetStmt doc for convert_to_guarded_return #20597 Add LetStmt doc for convert_to_guarded_return
• Add applicable on LetExpr for unwrap_tuple #20600 Add applicable on LetExpr for unwrap_tuple
• Add ops::AddAssign implement for IndentLevel #20601 Add ops::AddAssign implement for IndentLevel
• Add wrap multiple attr for wrap_unwrap_cfg_attr #20625 Add wrap multiple attr for wrap_unwrap_cfg_attr
• Add multiple generate for enum generate is, as, try_into #20685 Add multiple generate for enum generate is, as, try_into
• Add macro segment completion #20741 Add macro segment completion
• Add fixes for non_exhaustive_let diagnostic #20762 Add fixes for non_exhaustive_let diagnostic
• Improve tmp iterator variable name for convert_for_to_while_let #20979 Improve tmp iterator variable name for convert_for_to_while_let
• Support WhileExpr and ForExpr for add_label_to_loop #20984 Support WhileExpr and ForExpr for add_label_to_loop
• Implement thin-arrow completion in fn return position #21012 Implement thin-arrow completion in fn return position
• Support multiple variant for generate_from_impl_for_enum #21038 Support multiple variant for generate_from_impl_for_enum
• Improve assist qualified to top when on first segment #21042 Improve assist qualified to top when on first segment

[ChayimFriedman2]

First, this is better suited to be a Zulip topic or a discussion, not an issue.

Second, as you said, you've opened many PRs, and I'm afraid more than the team capacity. Personally, I always try to balance between reviewing and creating new code (which is naturally more fun), and when reviewing I try to give people-based treatment, not PR-based treatment, that is I try not to review too many PRs of the same person while there are PRs of others waiting, so I review your PRs from time to time, but you always add more...

[A4-Tacks]

so I review your PRs from time to time, but you always add more...

Perhaps we can also review some older fix PRs at the same time

[Natural-selection1]

Although I know that, in terms of quantity, these PRs have already been selected by you, perhaps it would be better if you could further choose up to ten or even five PRs that can significantly improve the development experience or enhance the user experience for priority review.

[workingjubilee]

I would further suggest that the author can speed things up by closing PRs for which the team has expressed that the motivation for them is weak. Even if you wish to revisit them later, there is no sense in leaving them open and possibly draining reviewer time that could be going into something that has either not been reviewed yet or that you think might actually get merged.

[A4-Tacks]

choose up to ten or even five PRs that can significantly improve the development experience or enhance the user experience for priority review.

Okay

author can speed things up by closing PRs for which the team has expressed that the motivation for them is weak.

If I close it, I may forget. Is it reasonable to change it to draft?

[MohammadKHC]

@A4-Tacks, you’re the man!
You’ve submitted so many PRs that the rust org is trying to figure out whether it should borrow or move rust-analyzer to you. Haha

[A4-Tacks]

First, this is better suited to be a Zulip topic or a discussion, not an issue.

Okay, I have created a Zulip topic as https://rust-lang.zulipchat.com/+arrow/channel/185405-t-compiler.2Frust-analyzer/topic/Request.20to.20review.20some.20old.20PRs

[A4-Tacks]

@ShoyuVanilla Do you have time to review some PRs?

[ShoyuVanilla]

@ShoyuVanilla Do you have time to review some PRs?

Yeah, I'll review them as many as I can manage to. I couldn't make much time to work on rust-analyzer these days 😅