feat: completion list suggests methods in the order we most likely want #16044

mustakimali · 2023-12-07T17:48:00Z

When typing MyType:: the completion items' order could be re-ordered based on how likely we want to select those:

Constructors: new like functions to be able to create the type,
Builder Methods: any builder methods available,
Constructors that take args: Any other function that creates Self,
Regular methods & associated functions (no change there)

In this photo, the order is:

new constructor is first
new_builder second is a builder method
aaaanew is a constructor that takes arguments, is third and is irrespective of its alphabetical order among names.

I've dropped my previous idea of highlighting these functions in the rustdoc (rust-lang/rust#107926)

rustbot · 2023-12-13T23:18:02Z

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

This has been warn-by-default for two years now and has already been added to the future-incompat lints in 1.68.

This reverts commit 6d2543b.

…n the macro definition site

…cros

…gnostic

Before Private functions have RawVisibility module, but were missed because take_types returned None early. After resolve_visibility returned None, Visibility::Public was set instead and private functions ended up being offered in autocompletion. Choosing such a function results in an immediate error diagnostic about using a private function. After Pattern match of take_types that returns None and query for Module-level visibility from the original_module Fix rust-lang#15134 - tested with a unit test and a manual end-to-end test of building rust-analyzer from my branch and opening the reproduction repository REVIEW Refactor to move scope_def_applicable and check function visibility from a module Please let me know what's the best way to add a unit tests to nameres, which is where the root cause was

…g method name

colon_complete_preferred_order_relevances

methods in render function

rustbot · 2023-12-13T23:31:06Z

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits (since this message was last posted):

27e3cff

basic test

12b67ef

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 7, 2023

mustakimali changed the title ~~chore: dot completion suggests new like functions first~~ feat: completion list suggests methods in the order we most likely want Dec 13, 2023

mustakimali marked this pull request as ready for review December 13, 2023 23:17

rustbot added has-merge-commits S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2023

lnicola and others added 23 commits December 13, 2023 23:22

Fix runnable cwd on Windows

983bc9a

Don't explicitly warn against semicolon_in_expressions_from_macros

7218995

This has been warn-by-default for two years now and has already been added to the future-incompat lints in 1.68.

Bump ra-ap-rustc_lexer

4c15158

Bump ra-ap-rustc_parse_format

e9bc90c

Revert "Temporarily revert delay_bug to delayed_bug change"

41a8497

This reverts commit 6d2543b.

Bump ra-ap-rustc_index and ra-ap-rustc_abi

23fb593

Insert fn call parens only if the parens inserted around field name

1364705

Improve macro descension API

99e4fc4

Implicit format args support

903086c

Resolve implicit format args in syntax highlighting

918ed50

Add test for implicit format args support through nested macro call

42eaebe

Ignore strings in token trees in syntax highlighting

7132bf5

Allow navigation targets to be duplicated when the focus range lies i…

28e26b5

…n the macro definition site

Simplify

ee81231

Fix diagnostics panicking when resolving to different files due to ma…

6f7dfac

…cros

make ParamLoweringMode accessible

747e8a5

fix: Don't print proc-macro panic backtraces in the logs

597cc1f

internal: switch to Arc::from_iter

a2d1c9c

Publish lsp-server 0.7.5

f0100e3

internal: Bump salsa

037c10a

Bump and unlock some dependencies

44abccd

feat: add trait_impl_reduntant_assoc_item diagnostic

dc5ea83

update: make each trait_impl_reduntant_assoc_item into individual dia…

288f9c6

…gnostic

cardoso and others added 25 commits December 13, 2023 23:22

Flip binexpr works for lhs binexpr

476f711

flip binexpr works for lhs cmp

d593e4b

fix: Fix item tree lowering pub(self) to pub()

38b82e0

fix: resolve Self type references in delegate method assist

b09a052

fix: preserve where clause in delegate method

7ca6ae5

fix: prefer keeping Self if it is in the same impl def

e1cbcf0

Make TraitEnvironment's constructor private

ee5e1e7

fix: Fix concat_bytes! expansion

5febc8f

WIP - Sort suggested imports by type for data types

f0c9f9b

Implement function type matching

3935da3

Cleanup

303edff

fix: Fix token downmapping being quadratic

61036ec

Fallback to method resolution on unresolved field access with matchin…

2508c29

…g method name

fix: Smaller spans for unresolved field and method diagnostics

fe65636

fix: Fix completion failing in format_args! with invalid template

43878c2

fix: tests

3283a39

fix: test

ca88056

undo debug change

2d58983

save

b081f24

Refactor completion relevance calculation

5150422

Remove unnecessary code and fix formatting

2e6c660

Refactor render.rs: Rename test function to

0eb68eb

colon_complete_preferred_order_relevances

Fix preferred order of constructors and builder

444fa3b

methods in render function

Refactor render.rs and function.rs

1eac62a

mustakimali force-pushed the mo-usefull-order branch from 652b132 to 1eac62a Compare December 13, 2023 23:24

Merge branch 'master' into mo-usefull-order

27e3cff

mustakimali closed this Dec 13, 2023

mustakimali mentioned this pull request Feb 17, 2024

rustdoc: Indicate struct can be created + fn rust-lang/rust#107926

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: completion list suggests methods in the order we most likely want #16044

feat: completion list suggests methods in the order we most likely want #16044

Uh oh!

mustakimali commented Dec 7, 2023 •

edited

Loading

Uh oh!

rustbot commented Dec 13, 2023

Uh oh!

rustbot commented Dec 13, 2023

Uh oh!

Uh oh!

feat: completion list suggests methods in the order we most likely want #16044

feat: completion list suggests methods in the order we most likely want #16044

Uh oh!

Conversation

mustakimali commented Dec 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 13, 2023

Uh oh!

rustbot commented Dec 13, 2023

Uh oh!

Uh oh!

mustakimali commented Dec 7, 2023 •

edited

Loading