Skip to content

Conversation

@inflation
Copy link
Contributor

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 29, 2025
Copy link
Member

@lnicola lnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lnicola lnicola enabled auto-merge March 29, 2025 13:35
@inflation
Copy link
Contributor Author

Kindly ping @davidbarsky on why it was changed in the first place (f25cb19). Is it intentional for lldb-dap or just an oversight?

@lnicola lnicola added this pull request to the merge queue Mar 29, 2025
@davidbarsky
Copy link
Contributor

I don’t remember. In my testing, I don’t think either lldb-dap or CodeLLDB needed the commit hash, but I wasn’t particularly thorough in my testing.

@lnicola
Copy link
Member

lnicola commented Mar 29, 2025

To me, it looks like lldb-dap just wants an array, and the rest of the change was just a refactoring.

@lnicola
Copy link
Member

lnicola commented Mar 29, 2025

By the way, llvm/llvm-project#106919 is now merged.

@davidbarsky
Copy link
Contributor

I think that change was merged when I wrote the commit where I refactored this code, but there wasn’t an lldb (or lldb-dap) release containing said changes. I think there might be one now?

Merged via the queue into rust-lang:master with commit fb133c8 Mar 29, 2025
11 checks passed
@inflation inflation deleted the push-xrwpqzsqxtuy branch March 29, 2025 14:05
@lnicola
Copy link
Member

lnicola commented Mar 29, 2025

Yeah, there is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to map Rust stdlib sources when debugging in Windows

4 participants