Replies: 2 comments
-
Sure, sounds good. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Great, opened a PR at #3299 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I was looking into the enum representations, and rustified_non_exhaustive_enum doesn't mention anything about undefined behavior (in contrast to rustified_enum). In my opinion, not mentioning it explicitly makes it seem like the
non_exhaustive
gets rid of UB, but AFAIK that's not the case.I've found #1757 that added UB remarks back in 2020, but on
rustified_non_exhaustive_enum
it's been dropped in #2473 (internally,EnumVariation::Rust
still says it's UB), and it now just links torustified_enum
.Would it make sense to copy the disclaimer from
rustified_enum
torustified_non_exhaustive_enum
or at least mention UB?Beta Was this translation helpful? Give feedback.
All reactions