Rollup merge of #144691 - xizheyin:suggest-confuse, r=estebank

jhpratt · web-flow · commit 1b39c3590c4d · 2025-08-01T00:38:20.000-04:00
Extend `is_case_difference` to handle digit-letter confusables

This PR extends `is_case_difference` to handle digit-letter confusables

Add support for detecting 0/O, 1/l, 5/S, 8/B, 9/g confusables in error suggestions.

r? `@estebank`
diff --git a/tests/ui/match_str_case_mismatch.stderr b/tests/ui/match_str_case_mismatch.stderr
@@ -18,7 +18,7 @@ error: this `match` arm has a differing case than its expression
 LL |         "~!@#$%^&*()-_=+Foo" => {},
    |         ^^^^^^^^^^^^^^^^^^^^
    |
-help: consider changing the case of this arm to respect `to_ascii_lowercase` (notice the capitalization difference)
+help: consider changing the case of this arm to respect `to_ascii_lowercase` (notice the capitalization)
    |
 LL -         "~!@#$%^&*()-_=+Foo" => {},
 LL +         "~!@#$%^&*()-_=+foo" => {},

Original file line number	Diff line number	Diff line change
@@ -18,7 +18,7 @@ error: this `match` arm has a differing case than its expression
`18`	`18`	`LL \| "~!@#$%^&*()-_=+Foo" => {},`
`19`	`19`	`\| ^^^^^^^^^^^^^^^^^^^^`
`20`	`20`	`\|`
`21`		-help: consider changing the case of this arm to respect `to_ascii_lowercase` (notice the capitalization difference)
	`21`	+help: consider changing the case of this arm to respect `to_ascii_lowercase` (notice the capitalization)
`22`	`22`	`\|`
`23`	`23`	`LL - "~!@#$%^&*()-_=+Foo" => {},`
`24`	`24`	`LL + "~!@#$%^&*()-_=+foo" => {},`