hmm

Author: bend-n

clippy_config/src/conf.rs

@@ -1,3 +1,4 @@
+#![allow(clippy::unnecessary_collect)]
 use crate::ClippyConfiguration;
 use crate::types::{
     DisallowedPath, DisallowedPathWithoutReplacement, MacroMatcher, MatchLintBehaviour, PubUnderscoreFieldsBehaviour,
@@ -959,10 +960,10 @@ fn deserialize(file: &SourceFile) -> TryConf {
                         // info for the user instead.
 
                         let names = conf.conf.module_item_order_groupings.grouping_names();
-                        let suggestion = suggest_candidate(grouping, names.iter().map(String::as_str))
+                        let suggestion = suggest_candidate(grouping, names.clone())
                             .map(|s| format!(" perhaps you meant `{s}`?"))
                             .unwrap_or_default();
-                        let names = names.iter().map(|s| format!("`{s}`")).join(", ");
+                        let names = names.map(|s| format!("`{s}`")).join(", ");
                         let message = format!(
                             "unknown ordering group: `{grouping}` was not specified in `module-items-ordered-within-groupings`,{suggestion} expected one of: {names}"
                         );

clippy_config/src/types.rs

@@ -422,8 +422,8 @@ impl SourceItemOrderingModuleItemGroupings {
         self.back_lut.get(item)
     }
 
-    pub fn grouping_names(&self) -> Vec<String> {
-        self.groups.iter().map(|(name, _)| name.clone()).collect()
+    pub fn grouping_names(&self) -> impl Iterator<Item = &str> + Clone {
+        self.groups.iter().map(|(name, _)| &**name)
     }
 
     pub fn is_grouping(&self, grouping: &str) -> bool {