test: method calls

Author: ada4a

tests/ui/needless_path_new.fixed

@@ -7,18 +7,40 @@ fn takes_path(_: &Path) {}
 
 fn takes_path_and_impl_path(_: &Path, _: impl AsRef<Path>) {}
 
+struct Foo;
+
+impl Foo {
+    fn takes_path(_: &Path) {}
+    fn takes_self_and_path(&self, _: &Path) {}
+    fn takes_path_and_impl_path(_: &Path, _: impl AsRef<Path>) {}
+    fn takes_self_and_path_and_impl_path(&self, _: &Path, _: impl AsRef<Path>) {}
+}
+
 fn main() {
+    let f = Foo;
+
     fs::write("foo.txt", "foo"); //~ needless_path_new
 
     fs::copy(
         "foo", //~ needless_path_new
         "bar", //~ needless_path_new
     );
 
+    Foo::takes_path(Path::new("foo"));
+
+    f.takes_self_and_path_and_impl_path(
+        Path::new("foo"),
+        "bar", //~ needless_path_new
+    );
+
     // no warning
     takes_path(Path::new("foo"));
 
     // the paramater that _could_ be passed directly, was
     // the parameter that could't, wasn't
-    takes_path_and_impl_path(Path::new("foo"), "foo");
+    takes_path_and_impl_path(Path::new("foo"), "bar");
+
+    // same but as a method
+    Foo::takes_path_and_impl_path(Path::new("foo"), "bar");
+    f.takes_self_and_path_and_impl_path(Path::new("foo"), "bar");
 }

tests/ui/needless_path_new.rs

@@ -7,18 +7,40 @@ fn takes_path(_: &Path) {}
 
 fn takes_path_and_impl_path(_: &Path, _: impl AsRef<Path>) {}
 
+struct Foo;
+
+impl Foo {
+    fn takes_path(_: &Path) {}
+    fn takes_self_and_path(&self, _: &Path) {}
+    fn takes_path_and_impl_path(_: &Path, _: impl AsRef<Path>) {}
+    fn takes_self_and_path_and_impl_path(&self, _: &Path, _: impl AsRef<Path>) {}
+}
+
 fn main() {
+    let f = Foo;
+
     fs::write(Path::new("foo.txt"), "foo"); //~ needless_path_new
 
     fs::copy(
         Path::new("foo"), //~ needless_path_new
         Path::new("bar"), //~ needless_path_new
     );
 
+    Foo::takes_path(Path::new("foo"));
+
+    f.takes_self_and_path_and_impl_path(
+        Path::new("foo"),
+        Path::new("bar"), //~ needless_path_new
+    );
+
     // no warning
     takes_path(Path::new("foo"));
 
     // the paramater that _could_ be passed directly, was
     // the parameter that could't, wasn't
-    takes_path_and_impl_path(Path::new("foo"), "foo");
+    takes_path_and_impl_path(Path::new("foo"), "bar");
+
+    // same but as a method
+    Foo::takes_path_and_impl_path(Path::new("foo"), "bar");
+    f.takes_self_and_path_and_impl_path(Path::new("foo"), "bar");
 }

tests/ui/needless_path_new.stderr

@@ -1,5 +1,5 @@
 error: the expression enclosed in `Path::new` implements `AsRef<Path>`
-  --> tests/ui/needless_path_new.rs:11:15
+  --> tests/ui/needless_path_new.rs:22:15
    |
 LL |     fs::write(Path::new("foo.txt"), "foo");
    |               ^^^^^^^^^^^^^^^^^^^^ help: remove the enclosing `Path::new`: `"foo.txt"`
@@ -8,16 +8,22 @@ LL |     fs::write(Path::new("foo.txt"), "foo");
    = help: to override `-D warnings` add `#[allow(clippy::needless_path_new)]`
 
 error: the expression enclosed in `Path::new` implements `AsRef<Path>`
-  --> tests/ui/needless_path_new.rs:14:9
+  --> tests/ui/needless_path_new.rs:25:9
    |
 LL |         Path::new("foo"),
    |         ^^^^^^^^^^^^^^^^ help: remove the enclosing `Path::new`: `"foo"`
 
 error: the expression enclosed in `Path::new` implements `AsRef<Path>`
-  --> tests/ui/needless_path_new.rs:15:9
+  --> tests/ui/needless_path_new.rs:26:9
    |
 LL |         Path::new("bar"),
    |         ^^^^^^^^^^^^^^^^ help: remove the enclosing `Path::new`: `"bar"`
 
-error: aborting due to 3 previous errors
+error: the expression enclosed in `Path::new` implements `AsRef<Path>`
+  --> tests/ui/needless_path_new.rs:33:9
+   |
+LL |         Path::new("bar"),
+   |         ^^^^^^^^^^^^^^^^ help: remove the enclosing `Path::new`: `"bar"`
+
+error: aborting due to 4 previous errors