Enable useless_let_if_seq

Author: nickdrozd

clippy_lints/src/loops/never_loop.rs

@@ -37,16 +37,14 @@ pub(super) fn check<'tcx>(
                 {
                     // If the block contains a break or continue, or if the loop has a label, `MachineApplicable` is not
                     // appropriate.
-                    let mut app = if !contains_any_break_or_continue(block) && label.is_none() {
+                    let app = if !contains_any_break_or_continue(block) && label.is_none() {
                         Applicability::MachineApplicable
+                    } else if !never_spans.is_empty() {
+                        Applicability::HasPlaceholders
                     } else {
                         Applicability::Unspecified
                     };
 
-                    if !never_spans.is_empty() {
-                        app = Applicability::HasPlaceholders;
-                    }
-
                     let mut suggestions = vec![(
                         for_span.with_hi(iterator.span.hi()),
                         for_to_if_let_sugg(cx, iterator, pat),

clippy_lints/src/matches/match_like_matches.rs

@@ -113,12 +113,14 @@ where
         };
 
         // strip potential borrows (#6503), but only if the type is a reference
-        let mut ex_new = ex;
-        if let ExprKind::AddrOf(BorrowKind::Ref, .., ex_inner) = ex.kind
+        let ex_new = if let ExprKind::AddrOf(BorrowKind::Ref, .., ex_inner) = ex.kind
             && let ty::Ref(..) = cx.typeck_results().expr_ty(ex_inner).kind()
         {
-            ex_new = ex_inner;
-        }
+            ex_inner
+        } else {
+            ex
+        };
+
         span_lint_and_sugg(
             cx,
             MATCH_LIKE_MATCHES_MACRO,

clippy_lints/src/needless_for_each.rs

@@ -76,6 +76,7 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessForEach {
             // and suggesting `for … in … { unsafe { } }` is a little ugly.
             && !matches!(body.value.kind, ExprKind::Block(Block { rules: BlockCheckMode::UnsafeBlock(_), .. }, ..))
         {
+            #[expect(clippy::useless_let_if_seq, reason = "suggestion is less readable")]
             let mut applicability = Applicability::MachineApplicable;
 
             // If any closure parameter has an explicit type specified, applying the lint would necessarily

clippy_lints/src/operators/cmp_owned.rs

@@ -93,6 +93,7 @@ fn check_op(cx: &LateContext<'_>, expr: &Expr<'_>, other: &Expr<'_>, left: bool)
 
             let arg_snip = snippet(cx, arg_span, "..");
             let expr_snip;
+            #[expect(clippy::useless_let_if_seq, reason = "too complicated to fix")]
             let eq_impl;
             if with_deref.is_implemented() && !arg_ty.peel_refs().is_str() {
                 expr_snip = format!("*{arg_snip}");

clippy_lints/src/redundant_type_annotations.rs

@@ -151,14 +151,12 @@ impl LateLintPass<'_> for RedundantTypeAnnotations {
                     }
                 },
                 hir::ExprKind::MethodCall(_, _, _, _) => {
-                    let mut is_ref = false;
-                    let mut ty_kind = &ty.kind;
-
                     // If the annotation is a ref we "peel" it
-                    if let hir::TyKind::Ref(_, mut_ty) = &ty.kind {
-                        is_ref = true;
-                        ty_kind = &mut_ty.ty.kind;
-                    }
+                    let (is_ref, ty_kind) = if let hir::TyKind::Ref(_, mut_ty) = &ty.kind {
+                        (true, &mut_ty.ty.kind)
+                    } else {
+                        (false, &ty.kind)
+                    };
 
                     if let hir::TyKind::Path(ty_path) = ty_kind
                         && let hir::QPath::Resolved(_, resolved_path_ty) = ty_path

tests/compile-test.rs

@@ -356,14 +356,13 @@ fn main() {
             _ => panic!("unknown speedtest: {speedtest} || accepted speedtests are: [ui, cargo, toml, internal]"),
         };
 
-        let iterations;
-        if let Ok(iterations_str) = std::env::var("SPEEDTEST_ITERATIONS") {
-            iterations = iterations_str
+        let iterations = if let Ok(iterations_str) = std::env::var("SPEEDTEST_ITERATIONS") {
+            iterations_str
                 .parse::<u64>()
-                .unwrap_or_else(|_| panic!("Couldn't parse `{iterations_str}`, please use a valid u64"));
+                .unwrap_or_else(|_| panic!("Couldn't parse `{iterations_str}`, please use a valid u64"))
         } else {
-            iterations = 1000;
-        }
+            1000
+        };
 
         let mut sum = 0;
         for _ in 0..iterations {

tests/dogfood.rs

@@ -103,6 +103,8 @@ fn run_clippy_for_package(project: &str) -> bool {
         "clippy::significant_drop_tightening",
         "-D",
         "clippy::tuple_array_conversions",
+        "-D",
+        "clippy::useless_let_if_seq",
     ]);
     if !cfg!(feature = "internal") {
         // running a clippy built without internal lints on the clippy source