Drop some checker because rustdoc already warn about them

Author: maxcnunes

clippy_lints/src/doc/broken_link.rs

@@ -9,8 +9,6 @@ pub fn check(cx: &LateContext<'_>, attrs: &[Attribute]) {
     for broken_link in BrokenLinkLoader::collect_spans_broken_link(attrs) {
         let reason_msg = match broken_link.reason {
             BrokenLinkReason::MultipleLines => "broken across multiple lines",
-            BrokenLinkReason::MissingCloseParenthesis => "missing close parenthesis",
-            BrokenLinkReason::WhiteSpace => "whitespace within url",
         };
 
         span_lint(
@@ -23,10 +21,13 @@ pub fn check(cx: &LateContext<'_>, attrs: &[Attribute]) {
 }
 
 /// The reason why a link is considered broken.
+// NOTE: We don't check these other cases because
+// rustdoc itself will check and warn about it:
+// - When a link url is broken across multiple lines in the URL path part
+// - When a link tag is missing the close parenthesis character at the end.
+// - When a link has whitespace within the url link.
 enum BrokenLinkReason {
     MultipleLines,
-    MissingCloseParenthesis,
-    WhiteSpace,
 }
 
 /// Broken link data.
@@ -98,21 +99,8 @@ impl BrokenLinkLoader {
                 && let AttrStyle::Outer = attr.style
             {
                 self.scan_line(sym.as_str(), attr.span);
-            } else {
-                if idx > 0 && self.active && self.processing_link_url {
-                    let prev_attr = &attrs[idx - 1];
-                    let prev_end_line = prev_attr.span.hi().0;
-                    self.record_broken_link(prev_end_line, BrokenLinkReason::MissingCloseParenthesis);
-                }
-                self.reset_lookup();
             }
         }
-
-        if self.active && self.processing_link_url {
-            let last_end_line = attrs.last().unwrap().span.hi().0;
-            self.record_broken_link(last_end_line, BrokenLinkReason::MissingCloseParenthesis);
-            self.reset_lookup();
-        }
     }
 
     fn scan_line(&mut self, line: &str, attr_span: Span) {
@@ -169,13 +157,6 @@ impl BrokenLinkLoader {
                 continue;
             }
 
-            if self.reading_link_url && c.is_whitespace() {
-                let pos_end = u32::try_from(pos).unwrap();
-                self.record_broken_link(pos_end, BrokenLinkReason::WhiteSpace);
-                self.reset_lookup();
-                continue;
-            }
-
             if !c.is_whitespace() {
                 self.reading_link_url = true;
             }

tests/ui/doc_broken_link.rs

@@ -49,23 +49,6 @@ pub fn doc_invalid_link_broken_url_scheme_part() {}
 //~^^ ERROR: possible broken doc link: broken across multiple lines
 pub fn doc_invalid_link_broken_url_host_part() {}
 
-// NOTE: We don't test doc links where the url is broken accross
-// multiple lines in the path part because that is something
-// rustdoc itself will check and warn about it.
-pub fn doc_invalid_link_broken_url_path_part() {}
-
-/// Test invalid link, url missing close parenthesis.
-/// [doc invalid link broken url missing close parenthesis](
-/// https://test.fake/doc_invalid_link_missing_close_parenthesis
-//~^^ ERROR: possible broken doc link: missing close parenthesis
-pub fn doc_invalid_link_missing_close_parenthesis() {}
-
-/// Test invalid link, url whitespace within url.
-/// [doc invalid link broken url whitespace within url](
-/// https://test.fake/doc_invalid_link_url whitespace_within_url)
-//~^^ ERROR: possible broken doc link: whitespace within url
-pub fn doc_invalid_link_url_whitespace_within_url() {}
-
 /// This might be considered a link false positive
 /// and should be ignored by this lint rule:
 /// Example of referencing some code with brackets [FakeType].

tests/ui/doc_broken_link.stderr

@@ -17,20 +17,5 @@ LL |   /// [doc invalid link broken url host part](https://test
 LL | | /// .fake/doc_invalid_link_broken_url_host_part)
    | |________________________________________________^
 
-error: possible broken doc link: missing close parenthesis
-  --> tests/ui/doc_broken_link.rs:58:5
-   |
-LL |   /// [doc invalid link broken url missing close parenthesis](
-   |  _____^
-LL | | /// https://test.fake/doc_invalid_link_missing_close_parenthesis
-   | |________________________________________________________________^
-
-error: possible broken doc link: whitespace within url
-  --> /Users/maxnunes/Development/forks/rust-clippy/tests/clippy.toml:1:40
-   |
-LL |   # default config for tests, overrides clippy.toml at the project root
-   |  ________________________________________^
-...  |
-
-error: aborting due to 4 previous errors
+error: aborting due to 2 previous errors