Create new lints with #[clippy::version = "nightly"]

Alexendoo · Alexendoo · commit 41c61ef221bf · 2025-02-26T16:05:23.000Z
diff --git a/book/src/development/adding_lints.md b/book/src/development/adding_lints.md
@@ -223,7 +223,7 @@ declare_clippy_lint! {
     /// ```rust
     /// // example code
     /// ```
-    #[clippy::version = "1.29.0"]
+    #[clippy::version = "nightly"]
     pub FOO_FUNCTIONS,
     pedantic,
     "function named `foo`, which is not a descriptive name"
@@ -580,7 +580,7 @@ declare_clippy_lint! {
     /// ```rust,ignore
     /// // A short example of improved code that doesn't trigger the lint
     /// ```
-    #[clippy::version = "1.29.0"]
+    #[clippy::version = "nightly"]
     pub FOO_FUNCTIONS,
     pedantic,
     "function named `foo`, which is not a descriptive name"
diff --git a/book/src/development/defining_lints.md b/book/src/development/defining_lints.md
@@ -169,10 +169,10 @@ declare_clippy_lint! {
     /// ```rust
     /// // example code which does not raise Clippy warning
     /// ```
-    #[clippy::version = "1.70.0"] // <- In which version was this implemented, keep it up to date!
+    #[clippy::version = "nightly"]
     pub LINT_NAME, // <- The lint name IN_ALL_CAPS
     pedantic, // <- The lint group
-    "default lint description" // <- A lint description, e.g. "A function has an unit return type."
+    "default lint description" // <- A lint description, e.g. "A function has an unit return type"
 }
 ```
 
diff --git a/book/src/development/infrastructure/changelog_update.md b/book/src/development/infrastructure/changelog_update.md
@@ -111,8 +111,8 @@ that label in the changelog. If you can, remove the `beta-accepted` labels
 
 ### 4. Update `clippy::version` attributes
 
-Next, make sure to check that the `#[clippy::version]` attributes for the added
-lints contain the correct version.
+Next, make sure to check that the `#[clippy::version]` attributes for the newly
+added, renamed and deprecated lints contain the correct version.
 
 [changelog]: https://github.com/rust-lang/rust-clippy/blob/master/CHANGELOG.md
 [forge]: https://forge.rust-lang.org/
diff --git a/clippy_dev/src/new_lint.rs b/clippy_dev/src/new_lint.rs
@@ -1,4 +1,4 @@
-use crate::utils::{clippy_project_root, clippy_version};
+use crate::utils::clippy_project_root;
 use indoc::{formatdoc, writedoc};
 use std::fmt::Write as _;
 use std::fs::{self, OpenOptions};
@@ -184,11 +184,6 @@ fn to_camel_case(name: &str) -> String {
         .collect()
 }
 
-pub(crate) fn get_stabilization_version() -> String {
-    let (minor, patch) = clippy_version();
-    format!("{minor}.{patch}.0")
-}
-
 fn get_test_file_contents(lint_name: &str, msrv: bool) -> String {
     let mut test = formatdoc!(
         r"
@@ -339,13 +334,12 @@ fn get_lint_declaration(name_upper: &str, category: &str) -> String {
                 /// ```no_run
                 /// // example code which does not raise clippy warning
                 /// ```
-                #[clippy::version = "{}"]
+                #[clippy::version = "nightly"]
                 pub {name_upper},
                 {category},
                 "default lint description"
             }}
         "#,
-        get_stabilization_version(),
     )
 }
 
diff --git a/clippy_dev/src/update_lints.rs b/clippy_dev/src/update_lints.rs
@@ -197,13 +197,12 @@ pub fn rename(old_name: &str, new_name: &str, uplift: bool) {
         });
     }
 
-    let version = crate::new_lint::get_stabilization_version();
     rewrite_file(Path::new("clippy_lints/src/deprecated_lints.rs"), |s| {
         insert_at_marker(
             s,
             "// end renamed lints. used by `cargo dev rename_lint`",
             &format!(
-                "#[clippy::version = \"{version}\"]\n    \
+                "#[clippy::version = \"nightly\"]\n    \
                 (\"{}\", \"{}\"),\n    ",
                 lint.old_name, lint.new_name,
             ),
@@ -333,12 +332,11 @@ pub fn deprecate(name: &str, reason: &str) {
     let deprecated_lints_path = &*clippy_project_root().join("clippy_lints/src/deprecated_lints.rs");
 
     if remove_lint_declaration(stripped_name, &mod_path, &mut lints).unwrap_or(false) {
-        let version = crate::new_lint::get_stabilization_version();
         rewrite_file(deprecated_lints_path, |s| {
             insert_at_marker(
                 s,
                 "// end deprecated lints. used by `cargo dev deprecate_lint`",
-                &format!("#[clippy::version = \"{version}\"]\n    (\"{prefixed_name}\", \"{reason}\"),\n    ",),
+                &format!("#[clippy::version = \"nightly\"]\n    (\"{prefixed_name}\", \"{reason}\"),\n    ",),
             )
         });
 
diff --git a/clippy_lints/src/deprecated_lints.rs b/clippy_lints/src/deprecated_lints.rs
@@ -40,7 +40,7 @@ declare_with_version! { DEPRECATED(DEPRECATED_VERSION): &[(&str, &str)] = &[
     ("clippy::pub_enum_variant_names", "`clippy::enum_variant_names` now covers this case via the `avoid-breaking-exported-api` config"),
     #[clippy::version = "1.54.0"]
     ("clippy::wrong_pub_self_convention", "`clippy::wrong_self_convention` now covers this case via the `avoid-breaking-exported-api` config"),
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     ("clippy::option_map_or_err_ok", "`clippy::manual_ok_or` covers this case"),
     // end deprecated lints. used by `cargo dev deprecate_lint`
 ]}
@@ -131,7 +131,7 @@ declare_with_version! { RENAMED(RENAMED_VERSION): &[(&str, &str)] = &[
     ("clippy::clone_double_ref", "suspicious_double_ref_op"),
     #[clippy::version = ""]
     ("clippy::cmp_nan", "invalid_nan_comparisons"),
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     ("clippy::double_neg", "double_negations"),
     #[clippy::version = ""]
     ("clippy::drop_bounds", "drop_bounds"),
diff --git a/clippy_lints/src/doc/mod.rs b/clippy_lints/src/doc/mod.rs
@@ -98,7 +98,7 @@ declare_clippy_lint! {
     /// ```no_run
     /// //! <code>[first](x)second</code>
     /// ```
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     pub DOC_LINK_CODE,
     nursery,
     "link with code back-to-back with other code"
@@ -475,7 +475,7 @@ declare_clippy_lint! {
     /// ///   and this line is overindented.
     /// # fn foo() {}
     /// ```
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     pub DOC_OVERINDENTED_LIST_ITEMS,
     style,
     "ensure list items are not overindented"
diff --git a/clippy_lints/src/loops/mod.rs b/clippy_lints/src/loops/mod.rs
@@ -734,7 +734,7 @@ declare_clippy_lint! {
     /// let mut some_slice = [1, 2, 3, 4, 5];
     /// some_slice.fill(0);
     /// ```
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     pub MANUAL_SLICE_FILL,
     style,
     "manually filling a slice with a value"
diff --git a/clippy_lints/src/matches/mod.rs b/clippy_lints/src/matches/mod.rs
@@ -1000,7 +1000,7 @@ declare_clippy_lint! {
     /// let a = func().ok();
     /// let b = func().err();
     /// ```
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     pub MANUAL_OK_ERR,
     complexity,
     "find manual implementations of `.ok()` or `.err()` on `Result`"
diff --git a/clippy_lints/src/mem_replace.rs b/clippy_lints/src/mem_replace.rs
@@ -62,7 +62,7 @@ declare_clippy_lint! {
     /// let mut an_option = Some(0);
     /// let taken = an_option.replace(1);
     /// ```
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     pub MEM_REPLACE_OPTION_WITH_SOME,
     style,
     "replacing an `Option` with `Some` instead of `replace()`"
diff --git a/clippy_lints/src/methods/mod.rs b/clippy_lints/src/methods/mod.rs
@@ -4313,7 +4313,7 @@ declare_clippy_lint! {
     /// use std::num::NonZeroUsize;
     /// const PLAYERS: NonZeroUsize = NonZeroUsize::new(3).unwrap();
     /// ```
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     pub USELESS_NONZERO_NEW_UNCHECKED,
     complexity,
     "using `NonZero::new_unchecked()` in a `const` context"
@@ -4336,7 +4336,7 @@ declare_clippy_lint! {
     /// ```no_run
     /// let _ = std::iter::repeat_n(10, 3);
     /// ```
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     pub MANUAL_REPEAT_N,
     style,
     "detect `repeat().take()` that can be replaced with `repeat_n()`"
@@ -4364,7 +4364,7 @@ declare_clippy_lint! {
     /// let s = "Lorem ipsum";
     /// &s.as_bytes()[1..5];
     /// ```
-     #[clippy::version = "1.86.0"]
+     #[clippy::version = "nightly"]
      pub SLICED_STRING_AS_BYTES,
      perf,
      "slicing a string and immediately calling as_bytes is less efficient and can lead to panics"
@@ -4404,7 +4404,7 @@ declare_clippy_lint! {
     ///     }
     /// }
     /// ```
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     pub RETURN_AND_THEN,
     restriction,
     "using `Option::and_then` or `Result::and_then` to chain a computation that returns an `Option` or a `Result`"
@@ -4431,7 +4431,7 @@ declare_clippy_lint! {
     /// let file = BufReader::new(std::fs::File::open("./bytes.txt").unwrap());
     /// file.bytes();
     /// ```
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     pub UNBUFFERED_BYTES,
     perf,
     "calling .bytes() is very inefficient when data is not in memory"
@@ -4456,7 +4456,7 @@ declare_clippy_lint! {
     ///    values.contains(&10)
     /// }
     /// ```
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     pub MANUAL_CONTAINS,
     perf,
     "unnecessary `iter().any()` on slices that can be replaced with `contains()`"
@@ -4478,7 +4478,7 @@ declare_clippy_lint! {
     /// ```no_run
     /// let _ = std::io::Error::other("bad".to_string());
     /// ```
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     pub IO_OTHER_ERROR,
     style,
     "calling `std::io::Error::new(std::io::ErrorKind::Other, _)`"
diff --git a/clippy_lints/src/precedence.rs b/clippy_lints/src/precedence.rs
@@ -37,7 +37,7 @@ declare_clippy_lint! {
     ///
     /// ### Example
     /// `0x2345 & 0xF000 >> 12` equals 5, while `(0x2345 & 0xF000) >> 12` equals 2
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     pub PRECEDENCE_BITS,
     restriction,
     "operations mixing bit shifting with bit combining/masking"
diff --git a/clippy_lints/src/single_option_map.rs b/clippy_lints/src/single_option_map.rs
@@ -30,7 +30,7 @@ declare_clippy_lint! {
     ///     param * 2
     /// }
     /// ```
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     pub SINGLE_OPTION_MAP,
     nursery,
     "Checks for functions with method calls to `.map(_)` on an arg of type `Option` as the outermost expression."
diff --git a/clippy_lints/src/unnecessary_semicolon.rs b/clippy_lints/src/unnecessary_semicolon.rs
@@ -29,7 +29,7 @@ declare_clippy_lint! {
     ///    println!("a is greater than 10");
     /// }
     /// ```
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     pub UNNECESSARY_SEMICOLON,
     pedantic,
     "unnecessary semicolon after expression returning `()`"
diff --git a/clippy_lints/src/unneeded_struct_pattern.rs b/clippy_lints/src/unneeded_struct_pattern.rs
@@ -32,7 +32,7 @@ declare_clippy_lint! {
     ///     None => 0,
     /// };
     /// ```
-    #[clippy::version = "1.86.0"]
+    #[clippy::version = "nightly"]
     pub UNNEEDED_STRUCT_PATTERN,
     style,
     "using struct pattern to match against unit variant"
diff --git a/clippy_lints/src/utils/internal_lints/lint_without_lint_pass.rs b/clippy_lints/src/utils/internal_lints/lint_without_lint_pass.rs
@@ -218,7 +218,7 @@ pub(super) fn is_lint_ref_type(cx: &LateContext<'_>, ty: &hir::Ty<'_>) -> bool {
 
 fn check_invalid_clippy_version_attribute(cx: &LateContext<'_>, item: &'_ Item<'_>) {
     if let Some(value) = extract_clippy_version_value(cx, item) {
-        if value.as_str() == "pre 1.29.0" {
+        if matches!(value.as_str(), "pre 1.29.0" | "nightly") {
             return;
         }
 
diff --git a/tests/ui-internal/check_clippy_version_attribute.rs b/tests/ui-internal/check_clippy_version_attribute.rs
@@ -34,6 +34,14 @@ declare_tool_lint! {
     report_in_external_macro: true
 }
 
+declare_tool_lint! {
+    #[clippy::version = "nightly"]
+    pub clippy::VALID_NIGHTLY,
+    Warn,
+    "Three",
+    report_in_external_macro: true
+}
+
 ///////////////////////
 // Invalid attributes
 ///////////////////////
@@ -82,6 +90,6 @@ mod internal_clippy_lints {
 }
 
 use crate::internal_clippy_lints::ALLOW_MISSING_ATTRIBUTE_ONE;
-declare_lint_pass!(Pass2 => [VALID_ONE, VALID_TWO, VALID_THREE, INVALID_ONE, INVALID_TWO, MISSING_ATTRIBUTE_ONE, MISSING_ATTRIBUTE_TWO, ALLOW_MISSING_ATTRIBUTE_ONE]);
+declare_lint_pass!(Pass2 => [VALID_ONE, VALID_TWO, VALID_THREE, VALID_NIGHTLY, INVALID_ONE, INVALID_TWO, MISSING_ATTRIBUTE_ONE, MISSING_ATTRIBUTE_TWO, ALLOW_MISSING_ATTRIBUTE_ONE]);
 
 fn main() {}
diff --git a/tests/ui-internal/check_clippy_version_attribute.stderr b/tests/ui-internal/check_clippy_version_attribute.stderr
@@ -1,5 +1,5 @@
 error: this item has an invalid `clippy::version` attribute
-  --> tests/ui-internal/check_clippy_version_attribute.rs:40:1
+  --> tests/ui-internal/check_clippy_version_attribute.rs:48:1
    |
 LL | / declare_tool_lint! {
 LL | |     #[clippy::version = "1.2.3.4.5.6"]
@@ -20,7 +20,7 @@ LL | #![deny(clippy::internal)]
    = note: this error originates in the macro `$crate::declare_tool_lint` which comes from the expansion of the macro `declare_tool_lint` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 error: this item has an invalid `clippy::version` attribute
-  --> tests/ui-internal/check_clippy_version_attribute.rs:48:1
+  --> tests/ui-internal/check_clippy_version_attribute.rs:56:1
    |
 LL | / declare_tool_lint! {
 LL | |     #[clippy::version = "I'm a string"]
@@ -35,7 +35,7 @@ LL | | }
    = note: this error originates in the macro `$crate::declare_tool_lint` which comes from the expansion of the macro `declare_tool_lint` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 error: this lint is missing the `clippy::version` attribute or version value
-  --> tests/ui-internal/check_clippy_version_attribute.rs:59:1
+  --> tests/ui-internal/check_clippy_version_attribute.rs:67:1
    |
 LL | / declare_tool_lint! {
 LL | |     #[clippy::version]
@@ -51,7 +51,7 @@ LL | | }
    = note: this error originates in the macro `$crate::declare_tool_lint` which comes from the expansion of the macro `declare_tool_lint` (in Nightly builds, run with -Z macro-backtrace for more info)
 
 error: this lint is missing the `clippy::version` attribute or version value
-  --> tests/ui-internal/check_clippy_version_attribute.rs:67:1
+  --> tests/ui-internal/check_clippy_version_attribute.rs:75:1
    |
 LL | / declare_tool_lint! {
 LL | |     pub clippy::MISSING_ATTRIBUTE_TWO,
diff --git a/util/gh-pages/script.js b/util/gh-pages/script.js
@@ -242,16 +242,17 @@ window.filters = {
             filters.allLints = Array.prototype.slice.call(
                 document.getElementsByTagName("article"),
             ).map(elem => {
-                let version = elem.querySelector(".label-version").innerText;
+                let versionText = elem.querySelector(".label-version").innerText;
                 // Strip the "pre " prefix for pre 1.29.0 lints
-                if (version.startsWith("pre ")) {
-                    version = version.slice(4);
+                if (versionText.startsWith("pre ")) {
+                    versionText = versionText.slice(4);
                 }
+                const version = versionText == "nightly" ? Infinity : versionText.split(".")[1];
                 return {
-                    elem: elem,
+                    elem,
                     group: elem.querySelector(".label-lint-group").innerText,
                     level: elem.querySelector(".label-lint-level").innerText,
-                    version: parseInt(version.split(".")[1]),
+                    version,
                     applicability: elem.querySelector(".label-applicability").innerText,
                     filteredOut: false,
                     searchFilteredOut: false,
