Skip to content

Commit 4673b25

Browse files
ada4aada4a
committed
clean-up a bit
1 parent e74d4bd commit 4673b25

File tree

7 files changed

+36
-40
lines changed

7 files changed

+36
-40
lines changed

‎clippy_lints/src/types/rc_buffer.rs‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
1919
cx,
2020
RC_BUFFER,
2121
hir_ty.span,
22-
"usage of `Rc<T>` when T is a buffer type",
22+
"usage of `Rc<T>` when `T` is a buffer type",
2323
|diag| {
2424
diag.span_suggestion(hir_ty.span, "try", format!("Rc<{alternate}>"), app);
2525
},
@@ -41,7 +41,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
4141
cx,
4242
RC_BUFFER,
4343
hir_ty.span,
44-
"usage of `Rc<T>` when T is a buffer type",
44+
"usage of `Rc<T>` when `T` is a buffer type",
4545
|diag| {
4646
let mut applicability = app;
4747
diag.span_suggestion(
@@ -64,7 +64,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
6464
cx,
6565
RC_BUFFER,
6666
hir_ty.span,
67-
"usage of `Arc<T>` when T is a buffer type",
67+
"usage of `Arc<T>` when `T` is a buffer type",
6868
|diag| {
6969
diag.span_suggestion(hir_ty.span, "try", format!("Arc<{alternate}>"), app);
7070
},
@@ -83,7 +83,7 @@ pub(super) fn check(cx: &LateContext<'_>, hir_ty: &hir::Ty<'_>, qpath: &QPath<'_
8383
cx,
8484
RC_BUFFER,
8585
hir_ty.span,
86-
"usage of `Arc<T>` when T is a buffer type",
86+
"usage of `Arc<T>` when `T` is a buffer type",
8787
|diag| {
8888
let mut applicability = app;
8989
diag.span_suggestion(

‎tests/ui/rc_buffer.fixed‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
#![warn(clippy::rc_buffer)]
2-
#![allow(dead_code, unused_imports)]
32

43
use std::cell::RefCell;
54
use std::ffi::OsString;

‎tests/ui/rc_buffer.rs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
#![warn(clippy::rc_buffer)]
2-
#![allow(dead_code, unused_imports)]
32

43
use std::cell::RefCell;
54
use std::ffi::OsString;

‎tests/ui/rc_buffer.stderr‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,50 +1,50 @@
1-
error: usage of `Rc<T>` when T is a buffer type
2-
--> tests/ui/rc_buffer.rs:11:11
1+
error: usage of `Rc<T>` when `T` is a buffer type
2+
--> tests/ui/rc_buffer.rs:10:11
33
|
44
LL | bad1: Rc<String>,
55
| ^^^^^^^^^^ help: try: `Rc<str>`
66
|
77
= note: `-D clippy::rc-buffer` implied by `-D warnings`
88
= help: to override `-D warnings` add `#[allow(clippy::rc_buffer)]`
99

10-
error: usage of `Rc<T>` when T is a buffer type
11-
--> tests/ui/rc_buffer.rs:13:11
10+
error: usage of `Rc<T>` when `T` is a buffer type
11+
--> tests/ui/rc_buffer.rs:12:11
1212
|
1313
LL | bad2: Rc<PathBuf>,
1414
| ^^^^^^^^^^^ help: try: `Rc<std::path::Path>`
1515

16-
error: usage of `Rc<T>` when T is a buffer type
17-
--> tests/ui/rc_buffer.rs:15:11
16+
error: usage of `Rc<T>` when `T` is a buffer type
17+
--> tests/ui/rc_buffer.rs:14:11
1818
|
1919
LL | bad3: Rc<Vec<u8>>,
2020
| ^^^^^^^^^^^ help: try: `Rc<[u8]>`
2121

22-
error: usage of `Rc<T>` when T is a buffer type
23-
--> tests/ui/rc_buffer.rs:17:11
22+
error: usage of `Rc<T>` when `T` is a buffer type
23+
--> tests/ui/rc_buffer.rs:16:11
2424
|
2525
LL | bad4: Rc<OsString>,
2626
| ^^^^^^^^^^^^ help: try: `Rc<std::ffi::OsStr>`
2727

28-
error: usage of `Rc<T>` when T is a buffer type
29-
--> tests/ui/rc_buffer.rs:24:17
28+
error: usage of `Rc<T>` when `T` is a buffer type
29+
--> tests/ui/rc_buffer.rs:23:17
3030
|
3131
LL | fn func_bad1(_: Rc<String>) {}
3232
| ^^^^^^^^^^ help: try: `Rc<str>`
3333

34-
error: usage of `Rc<T>` when T is a buffer type
35-
--> tests/ui/rc_buffer.rs:26:17
34+
error: usage of `Rc<T>` when `T` is a buffer type
35+
--> tests/ui/rc_buffer.rs:25:17
3636
|
3737
LL | fn func_bad2(_: Rc<PathBuf>) {}
3838
| ^^^^^^^^^^^ help: try: `Rc<std::path::Path>`
3939

40-
error: usage of `Rc<T>` when T is a buffer type
41-
--> tests/ui/rc_buffer.rs:28:17
40+
error: usage of `Rc<T>` when `T` is a buffer type
41+
--> tests/ui/rc_buffer.rs:27:17
4242
|
4343
LL | fn func_bad3(_: Rc<Vec<u8>>) {}
4444
| ^^^^^^^^^^^ help: try: `Rc<[u8]>`
4545

46-
error: usage of `Rc<T>` when T is a buffer type
47-
--> tests/ui/rc_buffer.rs:30:17
46+
error: usage of `Rc<T>` when `T` is a buffer type
47+
--> tests/ui/rc_buffer.rs:29:17
4848
|
4949
LL | fn func_bad4(_: Rc<OsString>) {}
5050
| ^^^^^^^^^^^^ help: try: `Rc<std::ffi::OsStr>`

‎tests/ui/rc_buffer_arc.fixed‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
#![warn(clippy::rc_buffer)]
2-
#![allow(dead_code, unused_imports)]
32

43
use std::ffi::OsString;
54
use std::path::PathBuf;

‎tests/ui/rc_buffer_arc.rs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
#![warn(clippy::rc_buffer)]
2-
#![allow(dead_code, unused_imports)]
32

43
use std::ffi::OsString;
54
use std::path::PathBuf;

‎tests/ui/rc_buffer_arc.stderr‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,50 +1,50 @@
1-
error: usage of `Arc<T>` when T is a buffer type
2-
--> tests/ui/rc_buffer_arc.rs:10:11
1+
error: usage of `Arc<T>` when `T` is a buffer type
2+
--> tests/ui/rc_buffer_arc.rs:9:11
33
|
44
LL | bad1: Arc<String>,
55
| ^^^^^^^^^^^ help: try: `Arc<str>`
66
|
77
= note: `-D clippy::rc-buffer` implied by `-D warnings`
88
= help: to override `-D warnings` add `#[allow(clippy::rc_buffer)]`
99

10-
error: usage of `Arc<T>` when T is a buffer type
11-
--> tests/ui/rc_buffer_arc.rs:12:11
10+
error: usage of `Arc<T>` when `T` is a buffer type
11+
--> tests/ui/rc_buffer_arc.rs:11:11
1212
|
1313
LL | bad2: Arc<PathBuf>,
1414
| ^^^^^^^^^^^^ help: try: `Arc<std::path::Path>`
1515

16-
error: usage of `Arc<T>` when T is a buffer type
17-
--> tests/ui/rc_buffer_arc.rs:14:11
16+
error: usage of `Arc<T>` when `T` is a buffer type
17+
--> tests/ui/rc_buffer_arc.rs:13:11
1818
|
1919
LL | bad3: Arc<Vec<u8>>,
2020
| ^^^^^^^^^^^^ help: try: `Arc<[u8]>`
2121

22-
error: usage of `Arc<T>` when T is a buffer type
23-
--> tests/ui/rc_buffer_arc.rs:16:11
22+
error: usage of `Arc<T>` when `T` is a buffer type
23+
--> tests/ui/rc_buffer_arc.rs:15:11
2424
|
2525
LL | bad4: Arc<OsString>,
2626
| ^^^^^^^^^^^^^ help: try: `Arc<std::ffi::OsStr>`
2727

28-
error: usage of `Arc<T>` when T is a buffer type
29-
--> tests/ui/rc_buffer_arc.rs:23:17
28+
error: usage of `Arc<T>` when `T` is a buffer type
29+
--> tests/ui/rc_buffer_arc.rs:22:17
3030
|
3131
LL | fn func_bad1(_: Arc<String>) {}
3232
| ^^^^^^^^^^^ help: try: `Arc<str>`
3333

34-
error: usage of `Arc<T>` when T is a buffer type
35-
--> tests/ui/rc_buffer_arc.rs:25:17
34+
error: usage of `Arc<T>` when `T` is a buffer type
35+
--> tests/ui/rc_buffer_arc.rs:24:17
3636
|
3737
LL | fn func_bad2(_: Arc<PathBuf>) {}
3838
| ^^^^^^^^^^^^ help: try: `Arc<std::path::Path>`
3939

40-
error: usage of `Arc<T>` when T is a buffer type
41-
--> tests/ui/rc_buffer_arc.rs:27:17
40+
error: usage of `Arc<T>` when `T` is a buffer type
41+
--> tests/ui/rc_buffer_arc.rs:26:17
4242
|
4343
LL | fn func_bad3(_: Arc<Vec<u8>>) {}
4444
| ^^^^^^^^^^^^ help: try: `Arc<[u8]>`
4545

46-
error: usage of `Arc<T>` when T is a buffer type
47-
--> tests/ui/rc_buffer_arc.rs:29:17
46+
error: usage of `Arc<T>` when `T` is a buffer type
47+
--> tests/ui/rc_buffer_arc.rs:28:17
4848
|
4949
LL | fn func_bad4(_: Arc<OsString>) {}
5050
| ^^^^^^^^^^^^^ help: try: `Arc<std::ffi::OsStr>`

0 commit comments

Comments
 (0)