fix: still check for dummy

Author: ada4a

clippy_lints/src/significant_drop_tightening.rs

@@ -246,6 +246,7 @@ impl<'ap, 'lc, 'others, 'stmt, 'tcx> StmtsChecker<'ap, 'lc, 'others, 'stmt, 'tcx
                     .any(|(id, _)| id == apa.first_block_hir_id);
                 // last stmt is not dummy
                 if let Some(last_stmt_span) = apa.last_stmt_span
+                    && !last_stmt_span.is_dummy()
                     // last stmt is not current
                     && last_stmt_span != self.ap.curr_stmt.span
                     && (block_equals_curr || block_is_ancestor)

tests/ui/significant_drop_tightening.fixed

@@ -1,5 +1,4 @@
-
-drop(inner);#![warn(clippy::significant_drop_tightening)]
+#![warn(clippy::significant_drop_tightening)]
 
 use std::sync::Mutex;
 
@@ -169,7 +168,6 @@ fn issue_15574() {
 
         fn start_send(inner: &std::sync::Mutex<Inner<Operation>>, token: &mut Token) -> bool {
             let mut inner = inner.lock().unwrap();
-            //~^ significant_drop_tightening
 
             // If there's a waiting receiver, pair up with it.
             if let Some(operation) = inner.receivers.try_select() {

tests/ui/significant_drop_tightening.rs

@@ -164,7 +164,6 @@ fn issue_15574() {
 
         fn start_send(inner: &std::sync::Mutex<Inner<Operation>>, token: &mut Token) -> bool {
             let mut inner = inner.lock().unwrap();
-            //~^ significant_drop_tightening
 
             // If there's a waiting receiver, pair up with it.
             if let Some(operation) = inner.receivers.try_select() {

tests/ui/significant_drop_tightening.stderr

@@ -83,24 +83,5 @@ LL |
 LL ~         
    |
 
-error: temporary with significant `Drop` can be early dropped
-  --> tests/ui/significant_drop_tightening.rs:166:21
-   |
-LL |           fn start_send(inner: &std::sync::Mutex<Inner<Operation>>, token: &mut Token) -> bool {
-   |  ______________________________________________________________________________________________-
-LL | |             let mut inner = inner.lock().unwrap();
-   | |                     ^^^^^
-...  |
-LL | |         }
-   | |_________- temporary `inner` is currently being dropped at the end of its contained scope
-   |
-   = note: this might lead to unnecessary resource contention
-help: drop the temporary after the end of its last usage
-  --> /home/ada4a/dev/minor/clippy/tests/clippy.toml:1:1
-   |
-LL + 
-LL ~ drop(inner);# default config for tests, overrides clippy.toml at the project root
-   |
-
-error: aborting due to 5 previous errors
+error: aborting due to 4 previous errors