|
1 | 1 | #![warn(clippy::use_last)]
|
2 | 2 |
|
3 |
| -fn dont_use_last() -> Option<i32> { |
| 3 | +fn dont_use_last() { |
4 | 4 | let x = vec![2, 3, 5];
|
5 |
| - let last_element = x.get(x.len() - 1); // ~ERROR Use x.last() |
6 |
| - last_element.map(|val| val + 1) // To avoid warnings |
| 5 | + let _ = x.get(x.len() - 1); // ~ERROR Use x.last() |
7 | 6 | }
|
8 | 7 |
|
9 |
| -fn indexing_two_from_end() -> Option<i32> { |
| 8 | +fn indexing_two_from_end() { |
10 | 9 | let x = vec![2, 3, 5];
|
11 |
| - let last_element = x.get(x.len() - 2); |
12 |
| - last_element.map(|val| val + 3) // To avoid warnings |
| 10 | + let _ = x.get(x.len() - 2); |
13 | 11 | }
|
14 | 12 |
|
15 |
| -fn index_into_last() -> i32 { |
| 13 | +fn index_into_last() { |
16 | 14 | let x = vec![2, 3, 5];
|
17 |
| - let last_element = x[x.len() - 1]; |
18 |
| - last_element + 1 // To avoid warnings |
| 15 | + let _ = x[x.len() - 1]; |
19 | 16 | }
|
20 | 17 |
|
21 |
| -// False positive test (currently failing) |
22 |
| -fn use_last_with_different_vec_length() -> Option<i32> { |
| 18 | +fn use_last_with_different_vec_length() { |
23 | 19 | let x = vec![2, 3, 5];
|
24 | 20 | let y = vec!['a', 'b', 'c'];
|
25 |
| - let last_element = x.get(y.len() - 1); |
26 |
| - last_element.map(|val| val + 1) |
| 21 | + let _ = x.get(y.len() - 1); |
27 | 22 | }
|
28 | 23 |
|
29 | 24 | fn main() {
|
30 |
| - let expected_value: i32 = 6; |
31 |
| - println!("Working..."); |
32 |
| - assert_eq!(dont_use_last(), Some(expected_value)); |
33 |
| - assert_eq!(indexing_two_from_end(), Some(expected_value)); |
34 |
| - assert_eq!(index_into_last(), expected_value); |
35 |
| - assert_eq!(use_last_with_different_vec_length(), Some(expected_value)); |
| 25 | + dont_use_last(); |
| 26 | + indexing_two_from_end(); |
| 27 | + index_into_last(); |
| 28 | + use_last_with_different_vec_length(); |
36 | 29 | }
|
0 commit comments