Fix suggestion for Box::new around macro invocation

Author: bluebear94

clippy_lints/src/default_box_assignments.rs

@@ -88,7 +88,7 @@ impl LateLintPass<'_> for DefaultBoxAssignments {
                     let suggestion = format!(
                         "{} = {}",
                         Sugg::hir_with_applicability(cx, lhs, "_", &mut app).deref(),
-                        Sugg::hir_with_applicability(cx, rhs_inner, "_", &mut app),
+                        Sugg::hir_with_context(cx, rhs_inner, expr.span.ctxt(), "_", &mut app),
                     );
 
                     diag.note("this creates a needless allocation").span_suggestion(

tests/ui/default_box_assignments.fixed

@@ -33,6 +33,12 @@ macro_rules! same {
     };
 }
 
+macro_rules! mac {
+    (three) => {
+        3u32
+    };
+}
+
 fn main() {
     let mut b = Box::new(1u32);
     *b = Default::default();
@@ -52,6 +58,9 @@ fn main() {
     *b = 5;
     //~^ default_box_assignments
 
+    *b = mac!(three);
+    //~^ default_box_assignments
+
     // No lint for assigning to Box<T> where T: !Default
     let mut b = Box::<str>::from("hi".to_string());
     b = Default::default();

tests/ui/default_box_assignments.rs

@@ -33,6 +33,12 @@ macro_rules! same {
     };
 }
 
+macro_rules! mac {
+    (three) => {
+        3u32
+    };
+}
+
 fn main() {
     let mut b = Box::new(1u32);
     b = Default::default();
@@ -52,6 +58,9 @@ fn main() {
     b = Box::new(5);
     //~^ default_box_assignments
 
+    b = Box::new(mac!(three));
+    //~^ default_box_assignments
+
     // No lint for assigning to Box<T> where T: !Default
     let mut b = Box::<str>::from("hi".to_string());
     b = Default::default();

tests/ui/default_box_assignments.stderr

@@ -17,28 +17,36 @@ LL |     *b = Box::new(t);
    = note: this creates a needless allocation
 
 error: creating a new box with default content
-  --> tests/ui/default_box_assignments.rs:38:5
+  --> tests/ui/default_box_assignments.rs:44:5
    |
 LL |     b = Default::default();
    |     ^^^^^^^^^^^^^^^^^^^^^^ help: replace existing content with default instead: `*b = Default::default()`
    |
    = note: this creates a needless allocation
 
 error: creating a new box with default content
-  --> tests/ui/default_box_assignments.rs:40:5
+  --> tests/ui/default_box_assignments.rs:46:5
    |
 LL |     b = Box::default();
    |     ^^^^^^^^^^^^^^^^^^ help: replace existing content with default instead: `*b = Default::default()`
    |
    = note: this creates a needless allocation
 
 error: creating a new box
-  --> tests/ui/default_box_assignments.rs:52:5
+  --> tests/ui/default_box_assignments.rs:58:5
    |
 LL |     b = Box::new(5);
    |     ^^^^^^^^^^^^^^^ help: replace existing content with inner value instead: `*b = 5`
    |
    = note: this creates a needless allocation
 
-error: aborting due to 5 previous errors
+error: creating a new box
+  --> tests/ui/default_box_assignments.rs:61:5
+   |
+LL |     b = Box::new(mac!(three));
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace existing content with inner value instead: `*b = mac!(three)`
+   |
+   = note: this creates a needless allocation
+
+error: aborting due to 6 previous errors