Added const associated items matching and static

Author: teofr

clippy_lints/src/float_literal.rs

@@ -1,5 +1,5 @@
 use clippy_utils::diagnostics::span_lint_and_then;
-use clippy_utils::numeric_literal;
+use clippy_utils::{ExprUseNode, expr_use_ctxt, numeric_literal};
 use rustc_ast::ast::{LitFloatType, LitKind};
 use rustc_errors::Applicability;
 use rustc_hir as hir;
@@ -129,7 +129,7 @@ impl<'tcx> LateLintPass<'tcx> for FloatLiteral {
                     );
                 }
             } else if digits > max as usize && count_digits(&float_str) < digits {
-                if digits >= 40 && is_const_item(cx, expr) {
+                if digits >= 40 && matches!(expr_use_ctxt(cx, expr).use_node(cx), ExprUseNode::ConstStatic(_)) {
                     // If a big enough number of digits is specified and it's a constant
                     // we assume the user is definining a constant, and excessive precision is ok
                     return;
@@ -209,14 +209,6 @@ impl FloatFormat {
     }
 }
 
-fn is_const_item(cx: &LateContext<'_>, expr: &hir::Expr<'_>) -> bool {
-    let parent = cx.tcx.parent_hir_node(expr.hir_id);
-    if let hir::Node::Item(itm) = parent {
-        return matches!(itm.kind, hir::ItemKind::Const(..));
-    }
-    false
-}
-
 fn maybe_let_stmt<'a>(cx: &LateContext<'a>, expr: &hir::Expr<'_>) -> Option<&'a hir::LetStmt<'a>> {
     let parent = cx.tcx.parent_hir_node(expr.hir_id);
     match parent {

tests/ui/excessive_precision.fixed

@@ -109,4 +109,24 @@ fn main() {
     //~^ excessive_precision
     const _: f32 = 1.01234567890123456789012345678901234567890;
     const _: f64 = 1.01234567890123456789012345678901234567890;
+
+    static STATIC1: f32 = 1.01234567890123456789012345678901234567890;
+    static STATIC2: f64 = 1.01234567890123456789012345678901234567890;
+
+    static mut STATIC_MUT1: f32 = 1.01234567890123456789012345678901234567890;
+    static mut STATIC_MUT2: f64 = 1.01234567890123456789012345678901234567890;
+}
+
+trait ExcessivelyPreciseTrait {
+    // Overly specified constants
+    const GOOD1: f32 = 1.01234567890123456789012345678901234567890;
+    const GOOD2: f64 = 1.01234567890123456789012345678901234567890;
+}
+
+struct ExcessivelyPreciseStruct;
+
+impl ExcessivelyPreciseStruct {
+    // Overly specified constants
+    const GOOD1: f32 = 1.01234567890123456789012345678901234567890;
+    const GOOD2: f64 = 1.01234567890123456789012345678901234567890;
 }

tests/ui/excessive_precision.rs

@@ -109,4 +109,24 @@ fn main() {
     //~^ excessive_precision
     const _: f32 = 1.01234567890123456789012345678901234567890;
     const _: f64 = 1.01234567890123456789012345678901234567890;
+
+    static STATIC1: f32 = 1.01234567890123456789012345678901234567890;
+    static STATIC2: f64 = 1.01234567890123456789012345678901234567890;
+
+    static mut STATIC_MUT1: f32 = 1.01234567890123456789012345678901234567890;
+    static mut STATIC_MUT2: f64 = 1.01234567890123456789012345678901234567890;
+}
+
+trait ExcessivelyPreciseTrait {
+    // Overly specified constants
+    const GOOD1: f32 = 1.01234567890123456789012345678901234567890;
+    const GOOD2: f64 = 1.01234567890123456789012345678901234567890;
+}
+
+struct ExcessivelyPreciseStruct;
+
+impl ExcessivelyPreciseStruct {
+    // Overly specified constants
+    const GOOD1: f32 = 1.01234567890123456789012345678901234567890;
+    const GOOD2: f64 = 1.01234567890123456789012345678901234567890;
 }