make dogfood tests happy

Author: y21

clippy_lints/src/missing_fields_in_debug.rs

@@ -88,7 +88,7 @@ const HELP_FIELD_REFERENCE: &str = "the field referenced by this binding is unus
 const HELP_INCLUDE_ALL_FIELDS: &str = "consider including all fields in this `Debug` impl";
 const HELP_FINISH_NON_EXHAUSTIVE: &str = "consider calling `.finish_non_exhaustive()` if you intend to ignore fields";
 
-fn report_lints<'tcx, I>(cx: &LateContext<'tcx>, span: Span, span_notes: I)
+fn report_lints<I>(cx: &LateContext<'_>, span: Span, span_notes: I)
 where
     I: Iterator<Item = (Span, &'static str)>,
 {
@@ -146,7 +146,7 @@ fn check_struct<'tcx>(
     cx: &LateContext<'tcx>,
     typeck_results: &TypeckResults<'tcx>,
     block: &'tcx Block<'tcx>,
-    self_ty: &rustc_middle::ty::Ty<'tcx>,
+    self_ty: rustc_middle::ty::Ty<'tcx>,
     item: &'tcx Item<'tcx>,
     data: &VariantData<'_>,
 ) {
@@ -156,7 +156,7 @@ fn check_struct<'tcx>(
         if_chain! {
             if let ExprKind::Field(target, ident) = expr.kind;
             let target_ty = typeck_results.expr_ty(target).peel_refs();
-            if target_ty == *self_ty;
+            if target_ty == self_ty;
             then {
                 field_accesses.insert(ident);
             }
@@ -168,10 +168,10 @@ fn check_struct<'tcx>(
         .fields()
         .iter()
         .filter_map(|field| {
-            if !field_accesses.contains(&field.ident) {
-                Some((field.span, HELP_FIELD_UNUSED))
-            } else {
+            if field_accesses.contains(&field.ident) {
                 None
+            } else {
+                Some((field.span, HELP_FIELD_UNUSED))
             }
         })
         .collect::<Vec<_>>();
@@ -191,14 +191,14 @@ fn check_enum<'tcx>(
     cx: &LateContext<'tcx>,
     typeck_results: &TypeckResults<'tcx>,
     block: &'tcx Block<'tcx>,
-    self_ty: &rustc_middle::ty::Ty<'tcx>,
+    self_ty: rustc_middle::ty::Ty<'tcx>,
     item: &'tcx Item<'tcx>,
 ) {
     let Some(arms) = for_each_expr(block, |expr| {
         if_chain! {
             if let ExprKind::Match(val, arms, MatchSource::Normal) = &expr.kind;
             if let match_ty = typeck_results.expr_ty(val).peel_refs();
-            if match_ty == *self_ty;
+            if match_ty == self_ty;
             then {
                 ControlFlow::Break(arms)
             } else {
@@ -284,8 +284,8 @@ impl<'tcx> LateLintPass<'tcx> for MissingFieldInDebug {
             if should_lint(cx, typeck_results, block);
             then {
                 match &self_item.kind {
-                    ItemKind::Struct(data, _) => check_struct(cx, typeck_results, block, &self_ty, item, data),
-                    ItemKind::Enum(..) => check_enum(cx, typeck_results, block, &self_ty, item),
+                    ItemKind::Struct(data, _) => check_struct(cx, typeck_results, block, self_ty, item, data),
+                    ItemKind::Enum(..) => check_enum(cx, typeck_results, block, self_ty, item),
                     _ => {}
                 }
             }