Add MSRV check for Result::unwrap_or_default()

This change ensures that the `unwrap_or_default` suggestion is only made for `Result` types when the MSRV is at least 1.16, since `Result::unwrap_or_default()` was stabilized in that version. The suggestion for `Option::unwrap_or_default()` remains available for all MSRVs.

- Add `RESULT_UNWRAP_OR_DEFAULT` constant to `msrv_aliases!` macro
- Update `check_unwrap_or_default` to only check MSRV for `Result` types
- Add test cases for both `Option` and `Result` with different MSRVs

Fixes #12973

Author: poglesbyg

.gitignore

@@ -46,3 +46,8 @@ helper.txt
 
 # mdbook generated output
 /book/book
+.cursorrules
+.cursor/rules/data-flow-analysis.mdc
+.giga/specifications.json
+.cursor/rules
+.cursor/rules/lint-implementation-patterns.mdc

clippy_lints/src/methods/or_fun_call.rs

@@ -45,8 +45,9 @@ pub(super) fn check<'tcx>(
         method_span: Span,
         msrv: Msrv,
     ) -> bool {
-        // Don't suggest unwrap_or_default if MSRV is less than 1.16
-        if !msrv.meets(cx, msrvs::STR_REPEAT) {
+        // Only check MSRV for Result type
+        let receiver_ty = cx.typeck_results().expr_ty_adjusted(receiver).peel_refs();
+        if is_type_diagnostic_item(cx, receiver_ty, sym::Result) && !msrv.meets(cx, msrvs::RESULT_UNWRAP_OR_DEFAULT) {
             return false;
         }
 

clippy_utils/src/msrvs.rs

@@ -76,7 +76,7 @@ msrv_aliases! {
     1,24,0 { IS_ASCII_DIGIT }
     1,18,0 { HASH_MAP_RETAIN, HASH_SET_RETAIN }
     1,17,0 { FIELD_INIT_SHORTHAND, STATIC_IN_CONST, EXPECT_ERR }
-    1,16,0 { STR_REPEAT }
+    1,16,0 { STR_REPEAT, RESULT_UNWRAP_OR_DEFAULT }
     1,15,0 { MAYBE_BOUND_IN_WHERE }
     1,13,0 { QUESTION_MARK_OPERATOR }
 }

tests/ui/or_fun_call.rs

@@ -409,4 +409,34 @@ fn fn_call_in_nested_expr() {
     //~^ or_fun_call
 }
 
+mod msrv_tests {
+    #[clippy::msrv = "1.15"]
+    fn test_option_below_msrv() {
+        let opt = Some(1);
+        let _ = opt.unwrap_or(0);
+        //~^ unwrap_or_default
+    }
+
+    #[clippy::msrv = "1.15"]
+    fn test_result_below_msrv() {
+        let res: Result<i32, ()> = Ok(1);
+        let _ = res.unwrap_or(0);
+        //~^ or_fun_call
+    }
+
+    #[clippy::msrv = "1.16"]
+    fn test_option_above_msrv() {
+        let opt = Some(1);
+        let _ = opt.unwrap_or(0);
+        //~^ unwrap_or_default
+    }
+
+    #[clippy::msrv = "1.16"]
+    fn test_result_above_msrv() {
+        let res: Result<i32, ()> = Ok(1);
+        let _ = res.unwrap_or(0);
+        //~^ unwrap_or_default
+    }
+}
+
 fn main() {}