reduce applicability when finding exprs with uncertain types

this makes the test case `unfixable`, so move it to a separate file

Author: ada4a

clippy_lints/src/no_effect.rs

@@ -272,11 +272,12 @@ fn has_no_effect(cx: &LateContext<'_>, expr: &Expr<'_>) -> bool {
 }
 
 fn check_unnecessary_operation(cx: &LateContext<'_>, stmt: &Stmt<'_>) {
+    let mut applicability = Applicability::MachineApplicable;
     if let StmtKind::Semi(expr) = stmt.kind
         && !stmt.span.in_external_macro(cx.sess().source_map())
         && let ctxt = stmt.span.ctxt()
         && expr.span.ctxt() == ctxt
-        && let Some(reduced) = reduce_expression(cx, expr)
+        && let Some(reduced) = reduce_expression(cx, expr, &mut applicability)
         && reduced.iter().all(|e| e.span.ctxt() == ctxt)
     {
         if let ExprKind::Index(..) = &expr.kind {
@@ -318,19 +319,18 @@ fn check_unnecessary_operation(cx: &LateContext<'_>, stmt: &Stmt<'_>) {
                 stmt.span,
                 "unnecessary operation",
                 |diag| {
-                    diag.span_suggestion(
-                        stmt.span,
-                        "statement can be reduced to",
-                        snippet,
-                        Applicability::MachineApplicable,
-                    );
+                    diag.span_suggestion(stmt.span, "statement can be reduced to", snippet, applicability);
                 },
             );
         }
     }
 }
 
-fn reduce_expression<'a>(cx: &LateContext<'_>, expr: &'a Expr<'a>) -> Option<Vec<&'a Expr<'a>>> {
+fn reduce_expression<'a>(
+    cx: &LateContext<'_>,
+    expr: &'a Expr<'a>,
+    applicability: &mut Applicability,
+) -> Option<Vec<&'a Expr<'a>>> {
     if expr.span.from_expansion() {
         return None;
     }
@@ -344,9 +344,9 @@ fn reduce_expression<'a>(cx: &LateContext<'_>, expr: &'a Expr<'a>) -> Option<Vec
         | ExprKind::Type(inner, _)
         | ExprKind::Unary(_, inner)
         | ExprKind::Field(inner, _)
-        | ExprKind::AddrOf(_, _, inner) => reduce_expression(cx, inner).or_else(|| Some(vec![inner])),
+        | ExprKind::AddrOf(_, _, inner) => reduce_expression(cx, inner, applicability).or_else(|| Some(vec![inner])),
         ExprKind::Cast(inner, _) if expr_type_is_certain(cx, inner) => {
-            reduce_expression(cx, inner).or_else(|| Some(vec![inner]))
+            reduce_expression(cx, inner, applicability).or_else(|| Some(vec![inner]))
         },
         // In the normal `Struct` case, we bail out if any of the fields has an uncertain type.
         // But for two-sided ranges, we know that if the type of one of the sides is certain, then so is the other
@@ -366,9 +366,12 @@ fn reduce_expression<'a>(cx: &LateContext<'_>, expr: &'a Expr<'a>) -> Option<Vec
             }
         },
         ExprKind::Struct(_, fields, ref base) => {
-            if fields.iter().any(|f| !expr_type_is_certain(cx, &f.expr))
-                || has_drop(cx, cx.typeck_results().expr_ty(expr))
-            {
+            if fields.iter().any(|f| !expr_type_is_certain(cx, f.expr)) {
+                // there's a risk that if we take the field exprs out of the context of the struct constructor,
+                // their types might become ambiguous
+                *applicability = Applicability::MaybeIncorrect;
+            }
+            if has_drop(cx, cx.typeck_results().expr_ty(expr)) {
                 None
             } else {
                 let base = match base {
@@ -404,7 +407,7 @@ fn reduce_expression<'a>(cx: &LateContext<'_>, expr: &'a Expr<'a>) -> Option<Vec
                         BlockCheckMode::UnsafeBlock(UnsafeSource::UserProvided) => None,
                         BlockCheckMode::DefaultBlock => Some(vec![&**e]),
                         // in case of compiler-inserted signaling blocks
-                        BlockCheckMode::UnsafeBlock(_) => reduce_expression(cx, e),
+                        BlockCheckMode::UnsafeBlock(_) => reduce_expression(cx, e, applicability),
                     }
                 })
             } else {

tests/ui/unnecessary_operation.fixed

@@ -157,15 +157,3 @@ fn issue15173_original<MsU>(handler: impl FnOnce() -> MsU + Clone + 'static) {
         None
     }) as Box<dyn Fn(i32) -> Option<i32>>;
 }
-
-fn issue15381() {
-    struct Resources;
-    struct DescriptorSet {
-        slots: Vec<Resources>,
-    }
-
-    fn main() {
-        Vec::new();
-        //~^ unnecessary_operation
-    }
-}

tests/ui/unnecessary_operation.rs

@@ -163,12 +163,3 @@ fn issue15173_original<MsU>(handler: impl FnOnce() -> MsU + Clone + 'static) {
         None
     }) as Box<dyn Fn(i32) -> Option<i32>>;
 }
-
-// don't lint if any of the fields has an ambiguous type when used by themselves
-fn issue15381() {
-    struct DescriptorSet {
-        slots: Vec<u32>,
-    }
-
-    DescriptorSet { slots: Vec::new() };
-}

tests/ui/unnecessary_operation.stderr

@@ -112,11 +112,20 @@ LL | |         get_number()
 LL | |     };
    | |______^ help: statement can be reduced to: `get_number();`
 
+error: unnecessary operation
+  --> tests/ui/unnecessary_operation.rs:109:5
+   |
+LL | /     FooString {
+LL | |
+LL | |         s: String::from("blah"),
+LL | |     };
+   | |______^ help: statement can be reduced to: `String::from("blah");`
+
 error: unnecessary operation
   --> tests/ui/unnecessary_operation.rs:150:5
    |
 LL |     [42, 55][get_usize()];
    |     ^^^^^^^^^^^^^^^^^^^^^^ help: statement can be written as: `assert!([42, 55].len() > get_usize());`
 
-error: aborting due to 19 previous errors
+error: aborting due to 20 previous errors
 

tests/ui/unnecessary_operation_unfixable.rs

@@ -0,0 +1,13 @@
+//@no-rustfix
+#![expect(unused)]
+#![warn(clippy::unnecessary_operation)]
+
+// don't lint if any of the fields has an ambiguous type when used by themselves
+fn issue15381() {
+    struct DescriptorSet {
+        slots: Vec<u32>,
+    }
+
+    DescriptorSet { slots: Vec::new() };
+    //~^ unnecessary_operation
+}

tests/ui/unnecessary_operation_unfixable.stderr

@@ -0,0 +1,11 @@
+error: unnecessary operation
+  --> tests/ui/unnecessary_operation_unfixable.rs:11:5
+   |
+LL |     DescriptorSet { slots: Vec::new() };
+   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `Vec::new();`
+   |
+   = note: `-D clippy::unnecessary-operation` implied by `-D warnings`
+   = help: to override `-D warnings` add `#[allow(clippy::unnecessary_operation)]`
+
+error: aborting due to 1 previous error
+