as_pointer_underscore: final touches

Author: Soveu

CHANGELOG.md

@@ -5193,7 +5193,6 @@ Released 2018-09-13
 <!-- begin autogenerated links to lint list -->
 [`absolute_paths`]: https://rust-lang.github.io/rust-clippy/master/index.html#absolute_paths
 [`absurd_extreme_comparisons`]: https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons
-[`accidental_double_ref_into_flat_addr_cast`]: https://rust-lang.github.io/rust-clippy/master/index.html#accidental_double_ref_into_flat_addr_cast
 [`alloc_instead_of_core`]: https://rust-lang.github.io/rust-clippy/master/index.html#alloc_instead_of_core
 [`allow_attributes`]: https://rust-lang.github.io/rust-clippy/master/index.html#allow_attributes
 [`allow_attributes_without_reason`]: https://rust-lang.github.io/rust-clippy/master/index.html#allow_attributes_without_reason
@@ -5204,6 +5203,7 @@ Released 2018-09-13
 [`arc_with_non_send_sync`]: https://rust-lang.github.io/rust-clippy/master/index.html#arc_with_non_send_sync
 [`arithmetic_side_effects`]: https://rust-lang.github.io/rust-clippy/master/index.html#arithmetic_side_effects
 [`as_conversions`]: https://rust-lang.github.io/rust-clippy/master/index.html#as_conversions
+[`as_pointer_underscore`]: https://rust-lang.github.io/rust-clippy/master/index.html#as_pointer_underscore
 [`as_ptr_cast_mut`]: https://rust-lang.github.io/rust-clippy/master/index.html#as_ptr_cast_mut
 [`as_underscore`]: https://rust-lang.github.io/rust-clippy/master/index.html#as_underscore
 [`assertions_on_constants`]: https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants

clippy_lints/src/casts/as_pointer_underscore.rs

@@ -6,19 +6,14 @@ pub fn check<'tcx>(cx: &LateContext<'tcx>, ty_into: Ty<'_>, cast_to_hir: &'tcx r
     if let rustc_hir::TyKind::Ptr(rustc_hir::MutTy { ty, .. }) = cast_to_hir.kind
         && matches!(ty.kind, rustc_hir::TyKind::Infer)
     {
-        clippy_utils::diagnostics::span_lint_and_then(
+        clippy_utils::diagnostics::span_lint_and_sugg(
             cx,
             super::AS_POINTER_UNDERSCORE,
             cast_to_hir.span,
             "using inferred pointer cast",
-            |diag| {
-                diag.span_suggestion(
-                    cast_to_hir.span,
-                    "use explicit type",
-                    ty_into,
-                    Applicability::MachineApplicable,
-                );
-            },
+            "use explicit type",
+            ty_into.to_string(),
+            Applicability::MachineApplicable,
         );
     }
 }