Revise diagnostic message

Author: bluebear94

clippy_lints/src/default_box_assignments.rs

@@ -51,7 +51,7 @@ impl LateLintPass<'_> for DefaultBoxAssignments {
                     cx,
                     DEFAULT_BOX_ASSIGNMENTS,
                     expr.span,
-                    "assigning `Default::default()` to `Box<T>`",
+                    "creating a new box with default content",
                     |diag| {
                         let mut app = Applicability::MachineApplicable;
                         let suggestion = format!(
@@ -61,7 +61,7 @@ impl LateLintPass<'_> for DefaultBoxAssignments {
 
                         diag.note("this creates a needless allocation").span_suggestion(
                             expr.span,
-                            "assign to the inner value",
+                            "replace existing content with default instead",
                             suggestion,
                             app,
                         );

tests/ui/default_box_assignments.stderr

@@ -1,18 +1,18 @@
-error: assigning `Default::default()` to `Box<T>`
+error: creating a new box with default content
   --> tests/ui/default_box_assignments.rs:11:5
    |
 LL |     b = Default::default();
-   |     ^^^^^^^^^^^^^^^^^^^^^^ help: assign to the inner value: `*b = Default::default()`
+   |     ^^^^^^^^^^^^^^^^^^^^^^ help: replace existing content with default instead: `*b = Default::default()`
    |
    = note: this creates a needless allocation
    = note: `-D clippy::default-box-assignments` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::default_box_assignments)]`
 
-error: assigning `Default::default()` to `Box<T>`
+error: creating a new box with default content
   --> tests/ui/default_box_assignments.rs:13:5
    |
 LL |     b = Box::default();
-   |     ^^^^^^^^^^^^^^^^^^ help: assign to the inner value: `*b = Default::default()`
+   |     ^^^^^^^^^^^^^^^^^^ help: replace existing content with default instead: `*b = Default::default()`
    |
    = note: this creates a needless allocation