Fix linter

Author: maxclaus

clippy_lints/src/doc/broken_link.rs

@@ -7,18 +7,18 @@ use rustc_span::{BytePos, Pos, Span};
 use super::DOC_BROKEN_LINK;
 
 /// Scan and report broken link on documents.
-/// It ignores false positives detected by pulldown_cmark, and only
+/// It ignores false positives detected by `pulldown_cmark`, and only
 /// warns users when the broken link is consider a URL.
 // NOTE: We don't check these other cases because
 // rustdoc itself will check and warn about it:
 // - When a link url is broken across multiple lines in the URL path part
 // - When a link tag is missing the close parenthesis character at the end.
 // - When a link has whitespace within the url link.
-pub fn check(cx: &LateContext<'_>, bl: &PullDownBrokenLink<'_>, doc: &String, fragments: &Vec<DocFragment>) {
+pub fn check(cx: &LateContext<'_>, bl: &PullDownBrokenLink<'_>, doc: &str, fragments: &[DocFragment]) {
     warn_if_broken_link(cx, bl, doc, fragments);
 }
 
-fn warn_if_broken_link(cx: &LateContext<'_>, bl: &PullDownBrokenLink<'_>, doc: &String, fragments: &Vec<DocFragment>) {
+fn warn_if_broken_link(cx: &LateContext<'_>, bl: &PullDownBrokenLink<'_>, doc: &str, fragments: &[DocFragment]) {
     if let Some(span) = source_span_for_markdown_range(cx.tcx, doc, &bl.span, fragments) {
         let mut len = 0;
 

clippy_lints/src/doc/mod.rs

@@ -781,6 +781,14 @@ struct DocHeaders {
 /// back in the various late lint pass methods if they need the final doc headers, like "Safety" or
 /// "Panics" sections.
 fn check_attrs(cx: &LateContext<'_>, valid_idents: &FxHashSet<String>, attrs: &[Attribute]) -> Option<DocHeaders> {
+    // We don't want the parser to choke on intra doc links. Since we don't
+    // actually care about rendering them, just pretend that all broken links
+    // point to a fake address.
+    #[expect(clippy::unnecessary_wraps)] // we're following a type signature
+    fn fake_broken_link_callback<'a>(_: BrokenLink<'_>) -> Option<(CowStr<'a>, CowStr<'a>)> {
+        Some(("fake".into(), "fake".into()))
+    }
+
     if suspicious_doc_comments::check(cx, attrs) || is_doc_hidden(attrs) {
         return None;
     }
@@ -815,30 +823,12 @@ fn check_attrs(cx: &LateContext<'_>, valid_idents: &FxHashSet<String>, attrs: &[
         return Some(DocHeaders::default());
     }
 
-    // We don't want the parser to choke on intra doc links. Since we don't
-    // actually care about rendering them, just pretend that all broken links
-    // point to a fake address.
-    // NOTE: use this full cb version only for the check_doc function.
-    // Otherwise, using it as callback for more functions will cause,
-    // duplicated diagnostics for the broken link checker.
-    // Use the light cb version for the other cases.
-    #[expect(clippy::unnecessary_wraps)] // we're following a type signature
-    let mut full_fake_broken_link_callback = |bl: BrokenLink<'_>| -> Option<(CowStr<'_>, CowStr<'_>)> {
-        broken_link::check(cx, &bl, &doc, &fragments);
-        Some(("fake".into(), "fake".into()))
-    };
-
-    #[expect(clippy::unnecessary_wraps)] // we're following a type signature
-    fn light_fake_broken_link_callback<'a>(_: BrokenLink<'_>) -> Option<(CowStr<'a>, CowStr<'a>)> {
-        Some(("fake".into(), "fake".into()))
-    }
-
     check_for_code_clusters(
         cx,
         pulldown_cmark::Parser::new_with_broken_link_callback(
             &doc,
             main_body_opts() - Options::ENABLE_SMART_PUNCTUATION,
-            Some(&mut light_fake_broken_link_callback),
+            Some(&mut fake_broken_link_callback),
         )
         .into_offset_iter(),
         &doc,
@@ -848,6 +838,13 @@ fn check_attrs(cx: &LateContext<'_>, valid_idents: &FxHashSet<String>, attrs: &[
         },
     );
 
+    // NOTE: check_doc uses it own cb function,
+    // to avoid causing duplicated diagnostics for the broken link checker.
+    let mut full_fake_broken_link_callback = |bl: BrokenLink<'_>| -> Option<(CowStr<'_>, CowStr<'_>)> {
+        broken_link::check(cx, &bl, &doc, &fragments);
+        Some(("fake".into(), "fake".into()))
+    };
+
     // disable smart punctuation to pick up ['link'] more easily
     let opts = main_body_opts() - Options::ENABLE_SMART_PUNCTUATION;
     let parser =