fix(ConstEvalCtxt): check if the const item is behind #[cfg]

Author: ada4a

clippy_utils/src/consts.rs

@@ -5,7 +5,7 @@
 #![allow(clippy::float_cmp)]
 
 use crate::source::{SpanRangeExt, walk_span_to_context};
-use crate::{clip, is_direct_expn_of, sext, unsext};
+use crate::{clip, inherits_cfg, is_direct_expn_of, sext, unsext};
 
 use rustc_abi::Size;
 use rustc_apfloat::Float;
@@ -643,16 +643,38 @@ impl<'tcx> ConstEvalCtxt<'tcx> {
                 if let Some(node) = self.tcx.hir_get_if_local(def_id)
                     && let Node::Item(Item {
                         kind: ItemKind::Const(.., body_id),
+                        owner_id,
                         ..
                     }) = node
-                    && let Node::Expr(Expr {
+                {
+                    // check for `const C: _ = cfg!(foo);`
+                    if let Node::Expr(Expr {
                         kind: ExprKind::Lit(_),
                         span,
                         ..
                     }) = self.tcx.hir_node(body_id.hir_id)
-                    && is_direct_expn_of(*span, sym::cfg).is_some()
-                {
-                    return None;
+                        && is_direct_expn_of(*span, sym::cfg).is_some()
+                    {
+                        return None;
+                    }
+
+                    // check for:
+                    // ```
+                    // #[cfg(foo)]
+                    // const C: _ = _;
+                    // ```
+                    //
+                    // NOTE: it shouldn't be possible to have `#[cfg]` applied to the initializer, because e.g.
+                    // something like this wouldn't work:
+                    // const C: _ = {
+                    //     #[cfg(foo)]
+                    //     1
+                    //     #[cfg(bar)]
+                    //     2
+                    // };
+                    if inherits_cfg(self.tcx, owner_id.def_id) {
+                        return None;
+                    }
                 }
 
                 let args = self.typeck.node_args(id);

tests/ui/bit_masks.rs

@@ -86,3 +86,15 @@ fn ineffective() {
     x | 3 > 4; // not an error (yet), better written as x >= 4
     x | 4 <= 19;
 }
+
+fn issue14167() {
+    #[cfg(test)]
+    const FORCE_DYNAMIC_DETECTION: u8 = 0b00010000;
+
+    #[cfg(not(test))]
+    const FORCE_DYNAMIC_DETECTION: u8 = 0b0000000;
+
+    const CAPS_STATIC: u8 = 0b00001111;
+
+    CAPS_STATIC & FORCE_DYNAMIC_DETECTION == 0;
+}