Rename trivial_map_over_range to map_with_unused_argument_over_ranges

This is plural and more accurately describes the lint.

Author: rspencer01

CHANGELOG.md

@@ -5559,6 +5559,7 @@ Released 2018-09-13
 [`map_flatten`]: https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten
 [`map_identity`]: https://rust-lang.github.io/rust-clippy/master/index.html#map_identity
 [`map_unwrap_or`]: https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or
+[`map_with_unused_argument_over_ranges`]: https://rust-lang.github.io/rust-clippy/master/index.html#map_with_unused_argument_over_ranges
 [`match_as_ref`]: https://rust-lang.github.io/rust-clippy/master/index.html#match_as_ref
 [`match_bool`]: https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
 [`match_like_matches_macro`]: https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
@@ -5885,7 +5886,6 @@ Released 2018-09-13
 [`transmutes_expressible_as_ptr_casts`]: https://rust-lang.github.io/rust-clippy/master/index.html#transmutes_expressible_as_ptr_casts
 [`transmuting_null`]: https://rust-lang.github.io/rust-clippy/master/index.html#transmuting_null
 [`trim_split_whitespace`]: https://rust-lang.github.io/rust-clippy/master/index.html#trim_split_whitespace
-[`trivial_map_over_range`]: https://rust-lang.github.io/rust-clippy/master/index.html#trivial_map_over_range
 [`trivial_regex`]: https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
 [`trivially_copy_pass_by_ref`]: https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
 [`try_err`]: https://rust-lang.github.io/rust-clippy/master/index.html#try_err

clippy_lints/src/declared_lints.rs

@@ -320,6 +320,7 @@ pub(crate) static LINTS: &[&crate::LintInfo] = &[
     crate::manual_unwrap_or_default::MANUAL_UNWRAP_OR_DEFAULT_INFO,
     crate::map_unit_fn::OPTION_MAP_UNIT_FN_INFO,
     crate::map_unit_fn::RESULT_MAP_UNIT_FN_INFO,
+    crate::map_with_unused_argument_over_ranges::MAP_WITH_UNUSED_ARGUMENT_OVER_RANGES_INFO,
     crate::match_result_ok::MATCH_RESULT_OK_INFO,
     crate::matches::COLLAPSIBLE_MATCH_INFO,
     crate::matches::INFALLIBLE_DESTRUCTURING_MATCH_INFO,
@@ -706,7 +707,6 @@ pub(crate) static LINTS: &[&crate::LintInfo] = &[
     crate::transmute::UNSOUND_COLLECTION_TRANSMUTE_INFO,
     crate::transmute::USELESS_TRANSMUTE_INFO,
     crate::transmute::WRONG_TRANSMUTE_INFO,
-    crate::trivial_map_over_range::TRIVIAL_MAP_OVER_RANGE_INFO,
     crate::tuple_array_conversions::TUPLE_ARRAY_CONVERSIONS_INFO,
     crate::types::BORROWED_BOX_INFO,
     crate::types::BOX_COLLECTION_INFO,

clippy_lints/src/lib.rs

@@ -217,6 +217,7 @@ mod manual_string_new;
 mod manual_strip;
 mod manual_unwrap_or_default;
 mod map_unit_fn;
+mod map_with_unused_argument_over_ranges;
 mod match_result_ok;
 mod matches;
 mod mem_replace;
@@ -346,7 +347,6 @@ mod to_string_trait_impl;
 mod trailing_empty_array;
 mod trait_bounds;
 mod transmute;
-mod trivial_map_over_range;
 mod tuple_array_conversions;
 mod types;
 mod unconditional_recursion;
@@ -1175,7 +1175,7 @@ pub fn register_lints(store: &mut rustc_lint::LintStore, conf: &'static Conf) {
     store.register_late_pass(move |_| Box::new(string_patterns::StringPatterns::new(msrv())));
     store.register_early_pass(|| Box::new(field_scoped_visibility_modifiers::FieldScopedVisibilityModifiers));
     store.register_late_pass(|_| Box::new(set_contains_or_insert::HashsetInsertAfterContains));
-    store.register_late_pass(|_| Box::new(trivial_map_over_range::TrivialMapOverRange));
+    store.register_late_pass(|_| Box::new(map_with_unused_argument_over_ranges::MapWithUnusedArgumentOverRanges));
     // add lints here, do not remove this comment, it's used in `new_lint`
 }
 

clippy_lints/src/trivial_map_over_range.rs renamed to clippy_lints/src/map_with_unused_argument_over_ranges.rs

@@ -10,7 +10,8 @@ use rustc_session::declare_lint_pass;
 declare_clippy_lint! {
     /// ### What it does
     ///
-    /// Lint to prevent trivial `map`s over ranges when one could use `take`.
+    /// Checks for `Iterator::map` over ranges without using the parameter which
+    /// could be more clearly expressed using `std::iter::repeat_with(...).take(...)`.
     ///
     /// ### Why is this bad?
     ///
@@ -27,14 +28,14 @@ declare_clippy_lint! {
     /// let f : Vec<_> = std::iter::repeat_with(|| { 3 + 1 }).take(10).collect();
     /// ```
     #[clippy::version = "1.81.0"]
-    pub TRIVIAL_MAP_OVER_RANGE,
+    pub MAP_WITH_UNUSED_ARGUMENT_OVER_RANGES,
     style,
     "map of a trivial closure (not dependent on parameter) over a range"
 }
 
-declare_lint_pass!(TrivialMapOverRange => [TRIVIAL_MAP_OVER_RANGE]);
+declare_lint_pass!(MapWithUnusedArgumentOverRanges => [MAP_WITH_UNUSED_ARGUMENT_OVER_RANGES]);
 
-impl LateLintPass<'_> for TrivialMapOverRange {
+impl LateLintPass<'_> for MapWithUnusedArgumentOverRanges {
     fn check_expr(&mut self, cx: &LateContext<'_>, ex: &Expr<'_>) {
         if let ExprKind::MethodCall(path, receiver, [map_arg_expr], _call_span) = ex.kind
             && path.ident.name == rustc_span::sym::map
@@ -56,7 +57,7 @@ impl LateLintPass<'_> for TrivialMapOverRange {
                     .replacen("|_|", "||", 1);
                 span_lint_and_sugg(
                     cx,
-                    TRIVIAL_MAP_OVER_RANGE,
+                    MAP_WITH_UNUSED_ARGUMENT_OVER_RANGES,
                     ex.span,
                     "map of a trivial closure (not dependent on parameter) over a range",
                     "use",
@@ -70,7 +71,7 @@ impl LateLintPass<'_> for TrivialMapOverRange {
                     .replacen("|_|", "||", 1);
                 span_lint_and_sugg(
                     cx,
-                    TRIVIAL_MAP_OVER_RANGE,
+                    MAP_WITH_UNUSED_ARGUMENT_OVER_RANGES,
                     ex.span,
                     "map of a trivial closure (not dependent on parameter) over a range",
                     "use",

tests/ui/trivial_map_over_range.fixed renamed to tests/ui/map_with_unused_argument_over_ranges.fixed

@@ -1,5 +1,5 @@
 #![allow(unused, clippy::redundant_closure)]
-#![warn(clippy::trivial_map_over_range)]
+#![warn(clippy::map_with_unused_argument_over_ranges)]
 
 fn do_something() -> usize {
     todo!()

tests/ui/trivial_map_over_range.rs renamed to tests/ui/map_with_unused_argument_over_ranges.rs

@@ -1,5 +1,5 @@
 #![allow(unused, clippy::redundant_closure)]
-#![warn(clippy::trivial_map_over_range)]
+#![warn(clippy::map_with_unused_argument_over_ranges)]
 
 fn do_something() -> usize {
     todo!()

tests/ui/trivial_map_over_range.stderr renamed to tests/ui/map_with_unused_argument_over_ranges.stderr

@@ -1,26 +1,26 @@
 error: map of a trivial closure (not dependent on parameter) over a range
-  --> tests/ui/trivial_map_over_range.rs:14:5
+  --> tests/ui/map_with_unused_argument_over_ranges.rs:14:5
    |
 LL |     (0..10).map(|_| do_something());
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `std::iter::repeat_with(|| do_something()).take(10)`
    |
-   = note: `-D clippy::trivial-map-over-range` implied by `-D warnings`
-   = help: to override `-D warnings` add `#[allow(clippy::trivial_map_over_range)]`
+   = note: `-D clippy::map-with-unused-argument-over-ranges` implied by `-D warnings`
+   = help: to override `-D warnings` add `#[allow(clippy::map_with_unused_argument_over_ranges)]`
 
 error: map of a trivial closure (not dependent on parameter) over a range
-  --> tests/ui/trivial_map_over_range.rs:15:5
+  --> tests/ui/map_with_unused_argument_over_ranges.rs:15:5
    |
 LL |     (3..10).map(|_| do_something());
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `std::iter::repeat_with(|| do_something()).take(7)`
 
 error: map of a trivial closure (not dependent on parameter) over a range
-  --> tests/ui/trivial_map_over_range.rs:16:5
+  --> tests/ui/map_with_unused_argument_over_ranges.rs:16:5
    |
 LL |     (0..10).map(|_| 3);
    |     ^^^^^^^^^^^^^^^^^^ help: use: `std::iter::repeat_with(|| 3).take(10)`
 
 error: map of a trivial closure (not dependent on parameter) over a range
-  --> tests/ui/trivial_map_over_range.rs:17:5
+  --> tests/ui/map_with_unused_argument_over_ranges.rs:17:5
    |
 LL | /     (0..10).map(|_| {
 LL | |         let x = 3;
@@ -37,19 +37,19 @@ LL ~     }).take(10);
    |
 
 error: map of a trivial closure (not dependent on parameter) over a range
-  --> tests/ui/trivial_map_over_range.rs:21:5
+  --> tests/ui/map_with_unused_argument_over_ranges.rs:21:5
    |
 LL |     (0..10).map(|_| do_something()).collect::<Vec<_>>();
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `std::iter::repeat_with(|| do_something()).take(10)`
 
 error: map of a trivial closure (not dependent on parameter) over a range
-  --> tests/ui/trivial_map_over_range.rs:23:5
+  --> tests/ui/map_with_unused_argument_over_ranges.rs:23:5
    |
 LL |     (0..upper).map(|_| do_something());
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `std::iter::repeat_with(|| do_something()).take(upper)`
 
 error: map of a trivial closure (not dependent on parameter) over a range
-  --> tests/ui/trivial_map_over_range.rs:25:5
+  --> tests/ui/map_with_unused_argument_over_ranges.rs:25:5
    |
 LL |     (0..upper_fn()).map(|_| do_something());
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `std::iter::repeat_with(|| do_something()).take(upper_fn())`

tests/ui/repeat_vec_with_capacity.fixed

@@ -1,4 +1,4 @@
-#![allow(clippy::trivial_map_over_range)]
+#![allow(clippy::map_with_unused_argument_over_ranges)]
 #![warn(clippy::repeat_vec_with_capacity)]
 
 fn main() {

tests/ui/repeat_vec_with_capacity.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::trivial_map_over_range)]
+#![allow(clippy::map_with_unused_argument_over_ranges)]
 #![warn(clippy::repeat_vec_with_capacity)]
 
 fn main() {