Rename the lint

Author: Artur-Sulej

CHANGELOG.md

@@ -6280,7 +6280,7 @@ Released 2018-09-13
 [`cyclomatic_complexity`]: https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
 [`dbg_macro`]: https://rust-lang.github.io/rust-clippy/master/index.html#dbg_macro
 [`debug_assert_with_mut_call`]: https://rust-lang.github.io/rust-clippy/master/index.html#debug_assert_with_mut_call
-[`decimal_bit_mask`]: https://rust-lang.github.io/rust-clippy/master/index.html#decimal_bit_mask
+[`decimal_bitwise_operands`]: https://rust-lang.github.io/rust-clippy/master/index.html#decimal_bitwise_operands
 [`decimal_literal_representation`]: https://rust-lang.github.io/rust-clippy/master/index.html#decimal_literal_representation
 [`declare_interior_mutable_const`]: https://rust-lang.github.io/rust-clippy/master/index.html#declare_interior_mutable_const
 [`default_constructed_unit_structs`]: https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs

clippy_lints/src/decimal_bit_mask.rs renamed to clippy_lints/src/decimal_bitwise_operands.rs

@@ -25,12 +25,12 @@ declare_clippy_lint! {
     /// let a = 0b1110 & 0b0110;
     /// ```
     #[clippy::version = "1.92.0"]
-    pub DECIMAL_BIT_MASK,
+    pub DECIMAL_BITWISE_OPERANDS,
     nursery,
     "use binary, hex, or octal literals for bitwise operations"
 }
 
-declare_lint_pass!(DecimalBitMask => [DECIMAL_BIT_MASK]);
+declare_lint_pass!(DecimalBitwiseOperands => [DECIMAL_BITWISE_OPERANDS]);
 
 fn check_bitwise_binary_expr(cx: &LateContext<'_>, expr: &Expr<'_>) {
     if let ExprKind::Binary(op, left, right) = &expr.kind
@@ -77,15 +77,15 @@ fn is_power_of_twoish(lit: &Spanned<LitKind>) -> bool {
 fn emit_lint(cx: &LateContext<'_>, span: Span) {
     span_lint_and_help(
         cx,
-        DECIMAL_BIT_MASK,
+        DECIMAL_BITWISE_OPERANDS,
         span,
         "using decimal literal for bitwise operation",
         None,
         "use binary (0b...), hex (0x...), or octal (0o...) notation for better readability",
     );
 }
 
-impl<'tcx> LateLintPass<'tcx> for DecimalBitMask {
+impl<'tcx> LateLintPass<'tcx> for DecimalBitwiseOperands {
     fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
         if expr.span.from_expansion() {
             return;

clippy_lints/src/declared_lints.rs

@@ -88,7 +88,7 @@ pub static LINTS: &[&::declare_clippy_lint::LintInfo] = &[
     crate::crate_in_macro_def::CRATE_IN_MACRO_DEF_INFO,
     crate::create_dir::CREATE_DIR_INFO,
     crate::dbg_macro::DBG_MACRO_INFO,
-    crate::decimal_bit_mask::DECIMAL_BIT_MASK_INFO,
+    crate::decimal_bitwise_operands::DECIMAL_BITWISE_OPERANDS_INFO,
     crate::default::DEFAULT_TRAIT_ACCESS_INFO,
     crate::default::FIELD_REASSIGN_WITH_DEFAULT_INFO,
     crate::default_constructed_unit_structs::DEFAULT_CONSTRUCTED_UNIT_STRUCTS_INFO,

clippy_lints/src/lib.rs

@@ -96,7 +96,7 @@ mod copy_iterator;
 mod crate_in_macro_def;
 mod create_dir;
 mod dbg_macro;
-mod decimal_bit_mask;
+mod decimal_bitwise_operands;
 mod default;
 mod default_constructed_unit_structs;
 mod default_instead_of_iter_empty;
@@ -846,7 +846,7 @@ pub fn register_lint_passes(store: &mut rustc_lint::LintStore, conf: &'static Co
         Box::new(|_| Box::new(cloned_ref_to_slice_refs::ClonedRefToSliceRefs::new(conf))),
         Box::new(|_| Box::new(infallible_try_from::InfallibleTryFrom)),
         Box::new(|_| Box::new(coerce_container_to_any::CoerceContainerToAny)),
-        Box::new(|_| Box::new(decimal_bit_mask::DecimalBitMask)),
+        Box::new(|_| Box::new(decimal_bitwise_operands::DecimalBitwiseOperands)),
         Box::new(|_| Box::new(toplevel_ref_arg::ToplevelRefArg)),
         Box::new(|_| Box::new(volatile_composites::VolatileComposites)),
         Box::new(|_| Box::<replace_box::ReplaceBox>::default()),

tests/ui/decimal_bit_mask.rs renamed to tests/ui/decimal_bitwise_operands.rs

@@ -1,6 +1,6 @@
 #![allow(clippy::erasing_op)]
 #![allow(clippy::no_effect)]
-#![warn(clippy::decimal_bit_mask)]
+#![warn(clippy::decimal_bitwise_operands)]
 
 macro_rules! bitwise_op {
     ($x:expr, $y:expr) => {
@@ -13,24 +13,24 @@ pub const SOME_CONST: i32 = 12345;
 fn main() {
     let mut x = 0;
     // BAD: Bitwise operation, decimal literal, one literal
-    x & 99; //~ decimal_bit_mask
-    x | (/* comment */99); //~ decimal_bit_mask
-    x ^ (99); //~ decimal_bit_mask
-    x &= 99; //~ decimal_bit_mask
-    x |= 99; //~ decimal_bit_mask
-    x ^= (99); //~ decimal_bit_mask
+    x & 99; //~ decimal_bitwise_operands
+    x | (/* comment */99); //~ decimal_bitwise_operands
+    x ^ (99); //~ decimal_bitwise_operands
+    x &= 99; //~ decimal_bitwise_operands
+    x |= 99; //~ decimal_bitwise_operands
+    x ^= (99); //~ decimal_bitwise_operands
 
     // BAD: Bitwise operation, decimal literal, two literals
-    0b1010 & 99; //~ decimal_bit_mask
-    0b1010 | (99); //~ decimal_bit_mask
-    0b1010 ^ (/* comment */99); //~ decimal_bit_mask
-    99 & 0b1010; //~ decimal_bit_mask
-    (99) | 0b1010; //~ decimal_bit_mask
-    (/* comment */99) ^ 0b1010; //~ decimal_bit_mask
-    0xD | 99; //~ decimal_bit_mask
+    0b1010 & 99; //~ decimal_bitwise_operands
+    0b1010 | (99); //~ decimal_bitwise_operands
+    0b1010 ^ (/* comment */99); //~ decimal_bitwise_operands
+    99 & 0b1010; //~ decimal_bitwise_operands
+    (99) | 0b1010; //~ decimal_bitwise_operands
+    (/* comment */99) ^ 0b1010; //~ decimal_bitwise_operands
+    0xD | 99; //~ decimal_bitwise_operands
     88 & 99;
-    //~^ decimal_bit_mask
-    //~| decimal_bit_mask
+    //~^ decimal_bitwise_operands
+    //~| decimal_bitwise_operands
 
     // GOOD: Bitwise operation, binary/hex/octal literal, one literal
     x & 0b1010;

tests/ui/decimal_bit_mask.stderr renamed to tests/ui/decimal_bitwise_operands.stderr

@@ -1,119 +1,119 @@
 error: using decimal literal for bitwise operation
-  --> tests/ui/decimal_bit_mask.rs:16:9
+  --> tests/ui/decimal_bitwise_operands.rs:16:9
    |
 LL |     x & 99;
    |         ^^
    |
    = help: use binary (0b...), hex (0x...), or octal (0o...) notation for better readability
-   = note: `-D clippy::decimal-bit-mask` implied by `-D warnings`
-   = help: to override `-D warnings` add `#[allow(clippy::decimal_bit_mask)]`
+   = note: `-D clippy::decimal-bitwise-operands` implied by `-D warnings`
+   = help: to override `-D warnings` add `#[allow(clippy::decimal_bitwise_operands)]`
 
 error: using decimal literal for bitwise operation
-  --> tests/ui/decimal_bit_mask.rs:17:23
+  --> tests/ui/decimal_bitwise_operands.rs:17:23
    |
 LL |     x | (/* comment */99);
    |                       ^^
    |
    = help: use binary (0b...), hex (0x...), or octal (0o...) notation for better readability
 
 error: using decimal literal for bitwise operation
-  --> tests/ui/decimal_bit_mask.rs:18:10
+  --> tests/ui/decimal_bitwise_operands.rs:18:10
    |
 LL |     x ^ (99);
    |          ^^
    |
    = help: use binary (0b...), hex (0x...), or octal (0o...) notation for better readability
 
 error: using decimal literal for bitwise operation
-  --> tests/ui/decimal_bit_mask.rs:19:10
+  --> tests/ui/decimal_bitwise_operands.rs:19:10
    |
 LL |     x &= 99;
    |          ^^
    |
    = help: use binary (0b...), hex (0x...), or octal (0o...) notation for better readability
 
 error: using decimal literal for bitwise operation
-  --> tests/ui/decimal_bit_mask.rs:20:10
+  --> tests/ui/decimal_bitwise_operands.rs:20:10
    |
 LL |     x |= 99;
    |          ^^
    |
    = help: use binary (0b...), hex (0x...), or octal (0o...) notation for better readability
 
 error: using decimal literal for bitwise operation
-  --> tests/ui/decimal_bit_mask.rs:21:11
+  --> tests/ui/decimal_bitwise_operands.rs:21:11
    |
 LL |     x ^= (99);
    |           ^^
    |
    = help: use binary (0b...), hex (0x...), or octal (0o...) notation for better readability
 
 error: using decimal literal for bitwise operation
-  --> tests/ui/decimal_bit_mask.rs:24:14
+  --> tests/ui/decimal_bitwise_operands.rs:24:14
    |
 LL |     0b1010 & 99;
    |              ^^
    |
    = help: use binary (0b...), hex (0x...), or octal (0o...) notation for better readability
 
 error: using decimal literal for bitwise operation
-  --> tests/ui/decimal_bit_mask.rs:25:15
+  --> tests/ui/decimal_bitwise_operands.rs:25:15
    |
 LL |     0b1010 | (99);
    |               ^^
    |
    = help: use binary (0b...), hex (0x...), or octal (0o...) notation for better readability
 
 error: using decimal literal for bitwise operation
-  --> tests/ui/decimal_bit_mask.rs:26:28
+  --> tests/ui/decimal_bitwise_operands.rs:26:28
    |
 LL |     0b1010 ^ (/* comment */99);
    |                            ^^
    |
    = help: use binary (0b...), hex (0x...), or octal (0o...) notation for better readability
 
 error: using decimal literal for bitwise operation
-  --> tests/ui/decimal_bit_mask.rs:27:5
+  --> tests/ui/decimal_bitwise_operands.rs:27:5
    |
 LL |     99 & 0b1010;
    |     ^^
    |
    = help: use binary (0b...), hex (0x...), or octal (0o...) notation for better readability
 
 error: using decimal literal for bitwise operation
-  --> tests/ui/decimal_bit_mask.rs:28:6
+  --> tests/ui/decimal_bitwise_operands.rs:28:6
    |
 LL |     (99) | 0b1010;
    |      ^^
    |
    = help: use binary (0b...), hex (0x...), or octal (0o...) notation for better readability
 
 error: using decimal literal for bitwise operation
-  --> tests/ui/decimal_bit_mask.rs:29:19
+  --> tests/ui/decimal_bitwise_operands.rs:29:19
    |
 LL |     (/* comment */99) ^ 0b1010;
    |                   ^^
    |
    = help: use binary (0b...), hex (0x...), or octal (0o...) notation for better readability
 
 error: using decimal literal for bitwise operation
-  --> tests/ui/decimal_bit_mask.rs:30:11
+  --> tests/ui/decimal_bitwise_operands.rs:30:11
    |
 LL |     0xD | 99;
    |           ^^
    |
    = help: use binary (0b...), hex (0x...), or octal (0o...) notation for better readability
 
 error: using decimal literal for bitwise operation
-  --> tests/ui/decimal_bit_mask.rs:31:5
+  --> tests/ui/decimal_bitwise_operands.rs:31:5
    |
 LL |     88 & 99;
    |     ^^
    |
    = help: use binary (0b...), hex (0x...), or octal (0o...) notation for better readability
 
 error: using decimal literal for bitwise operation
-  --> tests/ui/decimal_bit_mask.rs:31:10
+  --> tests/ui/decimal_bitwise_operands.rs:31:10
    |
 LL |     88 & 99;
    |          ^^