test: two params with the same generic

Author: ada4a

tests/ui/needless_path_new.fixed

@@ -7,6 +7,8 @@ fn takes_path(_: &Path) {}
 
 fn takes_path_and_impl_path(_: &Path, _: impl AsRef<Path>) {}
 
+fn takes_two_impl_paths_with_the_same_generic<P: AsRef<Path>>(_: P, _: P) {}
+
 struct Foo;
 
 impl Foo {
@@ -33,6 +35,12 @@ fn main() {
         "bar", //~ needless_path_new
     );
 
+    // we can and should change both at the same time
+    takes_two_impl_paths_with_the_same_generic(
+        "foo", //~ needless_path_new
+        "bar", //~ needless_path_new
+    );
+
     // no warning
     takes_path(Path::new("foo"));
 

tests/ui/needless_path_new.rs

@@ -7,6 +7,8 @@ fn takes_path(_: &Path) {}
 
 fn takes_path_and_impl_path(_: &Path, _: impl AsRef<Path>) {}
 
+fn takes_two_impl_paths_with_the_same_generic<P: AsRef<Path>>(_: P, _: P) {}
+
 struct Foo;
 
 impl Foo {
@@ -33,6 +35,12 @@ fn main() {
         Path::new("bar"), //~ needless_path_new
     );
 
+    // we can and should change both at the same time
+    takes_two_impl_paths_with_the_same_generic(
+        Path::new("foo"), //~ needless_path_new
+        Path::new("bar"), //~ needless_path_new
+    );
+
     // no warning
     takes_path(Path::new("foo"));
 

tests/ui/needless_path_new.stderr

@@ -1,5 +1,5 @@
 error: the expression enclosed in `Path::new` implements `AsRef<Path>`
-  --> tests/ui/needless_path_new.rs:22:15
+  --> tests/ui/needless_path_new.rs:24:15
    |
 LL |     fs::write(Path::new("foo.txt"), "foo");
    |               ^^^^^^^^^^^^^^^^^^^^ help: remove the enclosing `Path::new`: `"foo.txt"`
@@ -8,22 +8,34 @@ LL |     fs::write(Path::new("foo.txt"), "foo");
    = help: to override `-D warnings` add `#[allow(clippy::needless_path_new)]`
 
 error: the expression enclosed in `Path::new` implements `AsRef<Path>`
-  --> tests/ui/needless_path_new.rs:25:9
+  --> tests/ui/needless_path_new.rs:27:9
    |
 LL |         Path::new("foo"),
    |         ^^^^^^^^^^^^^^^^ help: remove the enclosing `Path::new`: `"foo"`
 
 error: the expression enclosed in `Path::new` implements `AsRef<Path>`
-  --> tests/ui/needless_path_new.rs:26:9
+  --> tests/ui/needless_path_new.rs:28:9
    |
 LL |         Path::new("bar"),
    |         ^^^^^^^^^^^^^^^^ help: remove the enclosing `Path::new`: `"bar"`
 
 error: the expression enclosed in `Path::new` implements `AsRef<Path>`
-  --> tests/ui/needless_path_new.rs:33:9
+  --> tests/ui/needless_path_new.rs:35:9
    |
 LL |         Path::new("bar"),
    |         ^^^^^^^^^^^^^^^^ help: remove the enclosing `Path::new`: `"bar"`
 
-error: aborting due to 4 previous errors
+error: the expression enclosed in `Path::new` implements `AsRef<Path>`
+  --> tests/ui/needless_path_new.rs:40:9
+   |
+LL |         Path::new("foo"),
+   |         ^^^^^^^^^^^^^^^^ help: remove the enclosing `Path::new`: `"foo"`
+
+error: the expression enclosed in `Path::new` implements `AsRef<Path>`
+  --> tests/ui/needless_path_new.rs:41:9
+   |
+LL |         Path::new("bar"),
+   |         ^^^^^^^^^^^^^^^^ help: remove the enclosing `Path::new`: `"bar"`
+
+error: aborting due to 6 previous errors