Rename default_box_assignments to replace_box

Author: bluebear94

CHANGELOG.md

@@ -90,7 +90,7 @@ pub static LINTS: &[&::declare_clippy_lint::LintInfo] = &[
     crate::dbg_macro::DBG_MACRO_INFO,
     crate::default::DEFAULT_TRAIT_ACCESS_INFO,
     crate::default::FIELD_REASSIGN_WITH_DEFAULT_INFO,
-    crate::default_box_assignments::DEFAULT_BOX_ASSIGNMENTS_INFO,
+    crate::replace_box::REPLACE_BOX_INFO,
     crate::default_constructed_unit_structs::DEFAULT_CONSTRUCTED_UNIT_STRUCTS_INFO,
     crate::default_instead_of_iter_empty::DEFAULT_INSTEAD_OF_ITER_EMPTY_INFO,
     crate::default_numeric_fallback::DEFAULT_NUMERIC_FALLBACK_INFO,

clippy_lints/src/declared_lints.rs

@@ -104,7 +104,6 @@ mod crate_in_macro_def;
 mod create_dir;
 mod dbg_macro;
 mod default;
-mod default_box_assignments;
 mod default_constructed_unit_structs;
 mod default_instead_of_iter_empty;
 mod default_numeric_fallback;
@@ -324,6 +323,7 @@ mod ref_patterns;
 mod reference;
 mod regex;
 mod repeat_vec_with_capacity;
+mod replace_box;
 mod reserve_after_initialization;
 mod return_self_not_must_use;
 mod returns;
@@ -833,6 +833,6 @@ pub fn register_lint_passes(store: &mut rustc_lint::LintStore, conf: &'static Co
     store.register_late_pass(|_| Box::new(coerce_container_to_any::CoerceContainerToAny));
     store.register_late_pass(|_| Box::new(toplevel_ref_arg::ToplevelRefArg));
     store.register_late_pass(|_| Box::new(volatile_composites::VolatileComposites));
-    store.register_late_pass(|_| Box::new(default_box_assignments::DefaultBoxAssignments));
+    store.register_late_pass(|_| Box::new(replace_box::ReplaceBox));
     // add lints here, do not remove this comment, it's used in `new_lint`
 }

clippy_lints/src/lib.rs

@@ -28,14 +28,14 @@ declare_clippy_lint! {
     /// let mut b = Box::new(1u32);
     /// *b = Default::default();
     /// ```
-    #[clippy::version = "1.89.0"]
-    pub DEFAULT_BOX_ASSIGNMENTS,
+    #[clippy::version = "1.92.0"]
+    pub REPLACE_BOX,
     perf,
     "assigning a newly created box to `Box<T>` is inefficient"
 }
-declare_lint_pass!(DefaultBoxAssignments => [DEFAULT_BOX_ASSIGNMENTS]);
+declare_lint_pass!(ReplaceBox => [REPLACE_BOX]);
 
-impl LateLintPass<'_> for DefaultBoxAssignments {
+impl LateLintPass<'_> for ReplaceBox {
     fn check_expr(&mut self, cx: &LateContext<'_>, expr: &'_ Expr<'_>) {
         if let ExprKind::Assign(lhs, rhs, _) = &expr.kind
             && !lhs.span.from_expansion()
@@ -60,7 +60,7 @@ impl LateLintPass<'_> for DefaultBoxAssignments {
             {
                 span_lint_and_then(
                     cx,
-                    DEFAULT_BOX_ASSIGNMENTS,
+                    REPLACE_BOX,
                     expr.span,
                     "creating a new box with default content",
                     |diag| {
@@ -83,7 +83,7 @@ impl LateLintPass<'_> for DefaultBoxAssignments {
             if inner_ty.is_sized(cx.tcx, cx.typing_env())
                 && let Some(rhs_inner) = get_box_new_payload(cx, rhs)
             {
-                span_lint_and_then(cx, DEFAULT_BOX_ASSIGNMENTS, expr.span, "creating a new box", |diag| {
+                span_lint_and_then(cx, REPLACE_BOX, expr.span, "creating a new box", |diag| {
                     let mut app = Applicability::MachineApplicable;
                     let suggestion = format!(
                         "{} = {}",

clippy_lints/src/default_box_assignments.rs renamed to clippy_lints/src/replace_box.rs

@@ -1,13 +1,13 @@
-#![warn(clippy::default_box_assignments)]
+#![warn(clippy::replace_box)]
 
 fn with_default<T: Default>(b: &mut Box<T>) {
     **b = T::default();
-    //~^ default_box_assignments
+    //~^ replace_box
 }
 
 fn with_sized<T>(b: &mut Box<T>, t: T) {
     **b = t;
-    //~^ default_box_assignments
+    //~^ replace_box
 }
 
 fn with_unsized<const N: usize>(b: &mut Box<[u32]>) {
@@ -42,9 +42,9 @@ macro_rules! mac {
 fn main() {
     let mut b = Box::new(1u32);
     *b = Default::default();
-    //~^ default_box_assignments
+    //~^ replace_box
     *b = Default::default();
-    //~^ default_box_assignments
+    //~^ replace_box
 
     // No lint for assigning to the storage
     *b = Default::default();
@@ -56,10 +56,10 @@ fn main() {
     same!(b) = Default::default();
 
     *b = 5;
-    //~^ default_box_assignments
+    //~^ replace_box
 
     *b = mac!(three);
-    //~^ default_box_assignments
+    //~^ replace_box
 
     // No lint for assigning to Box<T> where T: !Default
     let mut b = Box::<str>::from("hi".to_string());

tests/ui/default_box_assignments.fixed renamed to tests/ui/replace_box.fixed

@@ -1,13 +1,13 @@
-#![warn(clippy::default_box_assignments)]
+#![warn(clippy::replace_box)]
 
 fn with_default<T: Default>(b: &mut Box<T>) {
     *b = Box::new(T::default());
-    //~^ default_box_assignments
+    //~^ replace_box
 }
 
 fn with_sized<T>(b: &mut Box<T>, t: T) {
     *b = Box::new(t);
-    //~^ default_box_assignments
+    //~^ replace_box
 }
 
 fn with_unsized<const N: usize>(b: &mut Box<[u32]>) {
@@ -42,9 +42,9 @@ macro_rules! mac {
 fn main() {
     let mut b = Box::new(1u32);
     b = Default::default();
-    //~^ default_box_assignments
+    //~^ replace_box
     b = Box::default();
-    //~^ default_box_assignments
+    //~^ replace_box
 
     // No lint for assigning to the storage
     *b = Default::default();
@@ -56,10 +56,10 @@ fn main() {
     same!(b) = Default::default();
 
     b = Box::new(5);
-    //~^ default_box_assignments
+    //~^ replace_box
 
     b = Box::new(mac!(three));
-    //~^ default_box_assignments
+    //~^ replace_box
 
     // No lint for assigning to Box<T> where T: !Default
     let mut b = Box::<str>::from("hi".to_string());

tests/ui/default_box_assignments.rs renamed to tests/ui/replace_box.rs

@@ -1,47 +1,47 @@
 error: creating a new box
-  --> tests/ui/default_box_assignments.rs:4:5
+  --> tests/ui/replace_box.rs:4:5
    |
 LL |     *b = Box::new(T::default());
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace existing content with inner value instead: `**b = T::default()`
    |
    = note: this creates a needless allocation
-   = note: `-D clippy::default-box-assignments` implied by `-D warnings`
-   = help: to override `-D warnings` add `#[allow(clippy::default_box_assignments)]`
+   = note: `-D clippy::replace-box` implied by `-D warnings`
+   = help: to override `-D warnings` add `#[allow(clippy::replace_box)]`
 
 error: creating a new box
-  --> tests/ui/default_box_assignments.rs:9:5
+  --> tests/ui/replace_box.rs:9:5
    |
 LL |     *b = Box::new(t);
    |     ^^^^^^^^^^^^^^^^ help: replace existing content with inner value instead: `**b = t`
    |
    = note: this creates a needless allocation
 
 error: creating a new box with default content
-  --> tests/ui/default_box_assignments.rs:44:5
+  --> tests/ui/replace_box.rs:44:5
    |
 LL |     b = Default::default();
    |     ^^^^^^^^^^^^^^^^^^^^^^ help: replace existing content with default instead: `*b = Default::default()`
    |
    = note: this creates a needless allocation
 
 error: creating a new box with default content
-  --> tests/ui/default_box_assignments.rs:46:5
+  --> tests/ui/replace_box.rs:46:5
    |
 LL |     b = Box::default();
    |     ^^^^^^^^^^^^^^^^^^ help: replace existing content with default instead: `*b = Default::default()`
    |
    = note: this creates a needless allocation
 
 error: creating a new box
-  --> tests/ui/default_box_assignments.rs:58:5
+  --> tests/ui/replace_box.rs:58:5
    |
 LL |     b = Box::new(5);
    |     ^^^^^^^^^^^^^^^ help: replace existing content with inner value instead: `*b = 5`
    |
    = note: this creates a needless allocation
 
 error: creating a new box
-  --> tests/ui/default_box_assignments.rs:61:5
+  --> tests/ui/replace_box.rs:61:5
    |
 LL |     b = Box::new(mac!(three));
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace existing content with inner value instead: `*b = mac!(three)`