|
| 1 | +use clippy_config::Conf; |
| 2 | +use clippy_utils::diagnostics::span_lint_and_then; |
| 3 | +use clippy_utils::res::MaybeResPath as _; |
| 4 | +use clippy_utils::ty::is_copy; |
| 5 | +use clippy_utils::{get_enclosing_block, is_in_test}; |
| 6 | +use rustc_ast::BindingMode; |
| 7 | +use rustc_errors::Applicability; |
| 8 | +use rustc_hir::{Block, BorrowKind, Expr, ExprKind, Mutability, Node, PatKind}; |
| 9 | +use rustc_lint::{LateContext, LateLintPass}; |
| 10 | +use rustc_session::impl_lint_pass; |
| 11 | + |
| 12 | +declare_clippy_lint! { |
| 13 | + /// ### What it does |
| 14 | + /// Checks for taking a mutable reference on a freshly copied variable due to the use of a block returning a value implementing `Copy`. |
| 15 | + /// |
| 16 | + /// ### Why is this bad? |
| 17 | + /// Using a block will make a copy of the block result if its type |
| 18 | + /// implements `Copy`. This might be an indication of a failed attempt |
| 19 | + /// to borrow a variable. |
| 20 | + /// |
| 21 | + /// ### Example |
| 22 | + /// ```no_run |
| 23 | + /// # unsafe fn unsafe_func(_: &mut i32) {} |
| 24 | + /// let mut a = 10; |
| 25 | + /// let double_a_ref = &mut unsafe { // Unsafe block needed to call `unsafe_func` |
| 26 | + /// unsafe_func(&mut a); |
| 27 | + /// a |
| 28 | + /// }; |
| 29 | + /// ``` |
| 30 | + /// If you intend to take a reference on `a` and you need the block, |
| 31 | + /// create the reference inside the block instead: |
| 32 | + /// ```no_run |
| 33 | + /// # unsafe fn unsafe_func(_: &mut i32) {} |
| 34 | + /// let mut a = 10; |
| 35 | + /// let double_a_ref = unsafe { // Unsafe block needed to call `unsafe_func` |
| 36 | + /// unsafe_func(&mut a); |
| 37 | + /// &mut a |
| 38 | + /// }; |
| 39 | + /// ``` |
| 40 | + #[clippy::version = "1.90.0"] |
| 41 | + pub MUTABLE_BORROW_OF_COPY, |
| 42 | + suspicious, |
| 43 | + "mutable borrow of a data which was just copied" |
| 44 | +} |
| 45 | + |
| 46 | +pub struct MutableBorrowOfCopy { |
| 47 | + check_in_tests: bool, |
| 48 | +} |
| 49 | + |
| 50 | +impl MutableBorrowOfCopy { |
| 51 | + pub const fn new(conf: &Conf) -> Self { |
| 52 | + Self { |
| 53 | + check_in_tests: conf.check_mutable_borrow_of_copy_in_tests, |
| 54 | + } |
| 55 | + } |
| 56 | +} |
| 57 | + |
| 58 | +impl_lint_pass!(MutableBorrowOfCopy => [MUTABLE_BORROW_OF_COPY]); |
| 59 | + |
| 60 | +impl LateLintPass<'_> for MutableBorrowOfCopy { |
| 61 | + fn check_expr(&mut self, cx: &LateContext<'_>, expr: &Expr<'_>) { |
| 62 | + if !expr.span.from_expansion() |
| 63 | + && let ExprKind::AddrOf(BorrowKind::Ref, Mutability::Mut, sub_expr) = expr.kind |
| 64 | + && let ExprKind::Block(block, _) = sub_expr.kind |
| 65 | + && !block.targeted_by_break |
| 66 | + && block.span.eq_ctxt(expr.span) |
| 67 | + && let Some(block_expr) = block.expr |
| 68 | + && let block_ty = cx.typeck_results().expr_ty_adjusted(block_expr) |
| 69 | + && is_copy(cx, block_ty) |
| 70 | + && is_copied_defined_outside_block(cx, block_expr, block) |
| 71 | + && (self.check_in_tests || !is_in_test(cx.tcx, expr.hir_id)) |
| 72 | + { |
| 73 | + span_lint_and_then( |
| 74 | + cx, |
| 75 | + MUTABLE_BORROW_OF_COPY, |
| 76 | + expr.span, |
| 77 | + "mutable borrow of a value which was just copied", |
| 78 | + |diag| { |
| 79 | + diag.multipart_suggestion( |
| 80 | + "try building the reference inside the block", |
| 81 | + vec![ |
| 82 | + (expr.span.until(block.span), String::new()), |
| 83 | + (block_expr.span.shrink_to_lo(), String::from("&mut ")), |
| 84 | + ], |
| 85 | + Applicability::MaybeIncorrect, |
| 86 | + ); |
| 87 | + }, |
| 88 | + ); |
| 89 | + } |
| 90 | + } |
| 91 | +} |
| 92 | + |
| 93 | +/// Checks if `expr` denotes a mutable variable defined outside `block`. This peels away field |
| 94 | +/// accesses or indexing of such a variable first. |
| 95 | +fn is_copied_defined_outside_block(cx: &LateContext<'_>, mut expr: &Expr<'_>, block: &Block<'_>) -> bool { |
| 96 | + while let ExprKind::Field(base, _) | ExprKind::Index(base, _, _) = expr.kind { |
| 97 | + expr = base; |
| 98 | + } |
| 99 | + if let Some(mut current) = expr.res_local_id() |
| 100 | + && let Node::Pat(pat) = cx.tcx.hir_node(current) |
| 101 | + && matches!(pat.kind, PatKind::Binding(BindingMode::MUT, ..)) |
| 102 | + { |
| 103 | + // Scan enclosing blocks until we find `block` (if so, the local is defined within it), or we loop |
| 104 | + // or can't find blocks anymore. |
| 105 | + loop { |
| 106 | + match get_enclosing_block(cx, current).map(|b| b.hir_id) { |
| 107 | + Some(parent) if parent == block.hir_id => return false, |
| 108 | + Some(parent) if parent != current => current = parent, |
| 109 | + _ => return true, |
| 110 | + } |
| 111 | + } |
| 112 | + } |
| 113 | + false |
| 114 | +} |
0 commit comments