Fix duplicated diagnostics

Author: maxclaus

clippy_lints/src/doc/mod.rs

@@ -818,20 +818,27 @@ fn check_attrs(cx: &LateContext<'_>, valid_idents: &FxHashSet<String>, attrs: &[
     // We don't want the parser to choke on intra doc links. Since we don't
     // actually care about rendering them, just pretend that all broken links
     // point to a fake address.
+    // NOTE: use this full cb version only for the check_doc function.
+    // Otherwise, using it as callback for more functions will cause,
+    // duplicated diagnostics for the broken link checker.
+    // Use the light cb version for the other cases.
     #[expect(clippy::unnecessary_wraps)] // we're following a type signature
-    let fake_broken_link_callback = |bl: BrokenLink<'_>| -> Option<(CowStr<'_>, CowStr<'_>)> {
+    let mut full_fake_broken_link_callback = |bl: BrokenLink<'_>| -> Option<(CowStr<'_>, CowStr<'_>)> {
         broken_link::check(cx, &bl, &doc, &fragments);
         Some(("fake".into(), "fake".into()))
     };
 
-    let mut cb = fake_broken_link_callback;
+    #[expect(clippy::unnecessary_wraps)] // we're following a type signature
+    fn light_fake_broken_link_callback<'a>(_: BrokenLink<'_>) -> Option<(CowStr<'a>, CowStr<'a>)> {
+        Some(("fake".into(), "fake".into()))
+    }
 
     check_for_code_clusters(
         cx,
         pulldown_cmark::Parser::new_with_broken_link_callback(
             &doc,
             main_body_opts() - Options::ENABLE_SMART_PUNCTUATION,
-            Some(&mut cb),
+            Some(&mut light_fake_broken_link_callback),
         )
         .into_offset_iter(),
         &doc,
@@ -843,7 +850,8 @@ fn check_attrs(cx: &LateContext<'_>, valid_idents: &FxHashSet<String>, attrs: &[
 
     // disable smart punctuation to pick up ['link'] more easily
     let opts = main_body_opts() - Options::ENABLE_SMART_PUNCTUATION;
-    let parser = pulldown_cmark::Parser::new_with_broken_link_callback(&doc, opts, Some(&mut cb));
+    let parser =
+        pulldown_cmark::Parser::new_with_broken_link_callback(&doc, opts, Some(&mut full_fake_broken_link_callback));
 
     Some(check_doc(
         cx,

tests/ui/doc_broken_link.stderr

@@ -7,55 +7,23 @@ LL | /// [doc invalid link broken url scheme part](https://
    = note: `-D clippy::doc-broken-link` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::doc_broken_link)]`
 
-error: possible broken doc link: broken across multiple lines
-  --> tests/ui/doc_broken_link.rs:53:5
-   |
-LL | /// [doc invalid link broken url scheme part part](https://
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |
-   = note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`
-
 error: possible broken doc link: broken across multiple lines
   --> tests/ui/doc_broken_link.rs:59:5
    |
 LL | /// [doc invalid link broken url host part](https://test
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
-error: possible broken doc link: broken across multiple lines
-  --> tests/ui/doc_broken_link.rs:59:5
-   |
-LL | /// [doc invalid link broken url host part](https://test
-   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |
-   = note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`
-
-error: possible broken doc link: broken across multiple lines
-  --> tests/ui/doc_broken_link.rs:65:16
-   |
-LL | /// There is a [fist link - invalid](https://test
-   |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-error: possible broken doc link: broken across multiple lines
-  --> tests/ui/doc_broken_link.rs:68:80
-   |
-LL | /// with a [second link - valid](https://test.fake/doc_valid_link) and another [third link - invalid](https://test
-   |                                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
 error: possible broken doc link: broken across multiple lines
   --> tests/ui/doc_broken_link.rs:65:16
    |
 LL | /// There is a [fist link - invalid](https://test
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |
-   = note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`
 
 error: possible broken doc link: broken across multiple lines
   --> tests/ui/doc_broken_link.rs:68:80
    |
 LL | /// with a [second link - valid](https://test.fake/doc_valid_link) and another [third link - invalid](https://test
    |                                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-   |
-   = note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`
 
-error: aborting due to 8 previous errors
+error: aborting due to 4 previous errors