fix(multiple_inherent_impl): add lowercase config option + fix typo

Author: paulmialane

book/src/lint_configuration.md

@@ -674,7 +674,7 @@ A list of paths to types that should be treated as if they do not contain interi
 ## `inherent-impl-lint-scope`
 Sets the scope at which duplicate impl blocks for the same type are linted.
 
-**Default Value:** `"Crate"`
+**Default Value:** `"crate"`
 
 ---
 **Affected lints:**

clippy_config/src/types.rs

@@ -700,6 +700,7 @@ pub enum PubUnderscoreFieldsBehaviour {
 }
 
 #[derive(Clone, Copy, Debug, PartialEq, Eq, Deserialize, Serialize)]
+#[serde(rename_all = "lowercase")]
 pub enum InherentImplLintScope {
     Crate,
     File,

clippy_lints/src/inherent_impl.rs

@@ -15,8 +15,8 @@ declare_clippy_lint! {
     /// Checks for multiple inherent implementations of a struct
     ///
     /// The config option controls the scope at which multiple inherent impl blocks for the same
-    /// struct are linted, allowing values of "module" (only within the same module), "file"
-    /// (within the same file), or "crate" (anywhere in the crate, default).
+    /// struct are linted, allowing values of `module` (only within the same module), `file`
+    /// (within the same file), or `crate` (anywhere in the crate, default).
     ///
     /// ### Why restrict this?
     /// Splitting the implementation of a type makes the code harder to navigate.

tests/ui-cargo/multiple_inherent_impl/config_fail/Cargo.stderr

@@ -1,4 +1,4 @@
-error: error reading Clippy's configuration file: unknown variant `FooBar`, expected one of `Crate`, `File`, `Module`
+error: error reading Clippy's configuration file: unknown variant `FooBar`, expected one of `crate`, `file`, `module`
  --> $DIR/tests/ui-cargo/multiple_inherent_impl/config_fail/clippy.toml:1:28
   |
 1 | inherent-impl-lint-scope = "FooBar"

tests/ui-cargo/multiple_inherent_impl/crate_fail/Cargo.stderr

@@ -11,7 +11,7 @@ note: first implementation here
   --> src/main.rs:7:1
    |
  7 | / impl S {
- 8 | |     fn fisrt() {}
+ 8 | |     fn first() {}
  9 | | }
    | |_^
 note: the lint level is defined here
@@ -33,7 +33,7 @@ note: first implementation here
   --> src/main.rs:16:1
    |
 16 | / impl T {
-17 | |     fn fisrt() {}
+17 | |     fn first() {}
 18 | | }
    | |_^
 

tests/ui-cargo/multiple_inherent_impl/crate_fail/clippy.toml

@@ -1 +1 @@
-inherent-impl-lint-scope = "Crate"
+inherent-impl-lint-scope = "crate"

tests/ui-cargo/multiple_inherent_impl/crate_fail/src/main.rs

@@ -5,7 +5,7 @@ struct S;
 struct T;
 
 impl S {
-    fn fisrt() {}
+    fn first() {}
 }
 
 impl S {
@@ -14,7 +14,7 @@ impl S {
 }
 
 impl T {
-    fn fisrt() {}
+    fn first() {}
 }
 
 mod a {
@@ -29,7 +29,7 @@ mod b;
 
 impl b::S {
     //^ Must NOT trigger
-    fn fisrt() {}
+    fn first() {}
     fn second() {}
 }
 

tests/ui-cargo/multiple_inherent_impl/file_fail/Cargo.stderr

@@ -11,7 +11,7 @@ note: first implementation here
   --> src/main.rs:6:1
    |
  6 | / impl S {
- 7 | |     fn fisrt() {}
+ 7 | |     fn first() {}
  8 | | }
    | |_^
 note: the lint level is defined here
@@ -34,7 +34,7 @@ note: first implementation here
   --> src/main.rs:22:5
    |
 22 | /     impl S {
-23 | |         fn fisrt() {}
+23 | |         fn first() {}
 24 | |     }
    | |_____^
 
@@ -51,7 +51,7 @@ note: first implementation here
   --> src/c.rs:10:5
    |
 10 | /     impl T {
-11 | |         fn fisrt() {}
+11 | |         fn first() {}
 12 | |     }
    | |_____^
 

tests/ui-cargo/multiple_inherent_impl/file_fail/clippy.toml

@@ -1 +1 @@
-inherent-impl-lint-scope = "File"
+inherent-impl-lint-scope = "file"

tests/ui-cargo/multiple_inherent_impl/file_fail/src/c.rs

@@ -2,13 +2,13 @@ pub struct S;
 struct T;
 
 impl S {
-    fn fisrt() {}
+    fn first() {}
 }
 
 mod d {
     use super::T;
     impl T {
-        fn fisrt() {}
+        fn first() {}
     }
 }